> On Jan. 14, 2015, 10:20 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java, > > line 1683 > > <https://reviews.apache.org/r/29880/diff/1/?file=820818#file820818line1683> > > > > Can we put a smaller method name and the this intent in javadoc?
Please suggest a new name. > On Jan. 14, 2015, 10:20 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 1341 > > <https://reviews.apache.org/r/29880/diff/1/?file=820817#file820817line1341> > > > > Should we change this to info? > > Why we are catching all exceptions? Yes we can change to INFO. The method called here, CubeMetaStoreClient.getPartitionsByFilter, is catching all exceptions and then wrapping them up into HiveException. Code can catch HiveException instead of all exception here but that would indirectly be same as catching all exceptions. Will change to HiveException. - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29880/#review68034 ----------------------------------------------------------- On Jan. 14, 2015, 9:49 a.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29880/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 9:49 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > The storage table whose partition does not have input time dimension is > ignored while figuring out latest date. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 19deea6 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 28f6aa4 > > Diff: https://reviews.apache.org/r/29880/diff/ > > > Testing > ------- > > Added new test case for the scenario. > All existing test cases passed. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.349s] > [INFO] Lens .............................................. SUCCESS [2.840s] > [INFO] Lens API .......................................... SUCCESS [7.005s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.401s] > [INFO] Lens Cube ......................................... SUCCESS [7:41.749s] > [INFO] Lens DB storage ................................... SUCCESS [12.403s] > [INFO] Lens Query Library ................................ SUCCESS [6.629s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:23.053s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [4.786s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [31.316s] > [INFO] Lens Server ....................................... SUCCESS [8:57.475s] > [INFO] Lens client ....................................... SUCCESS [32.780s] > [INFO] Lens CLI .......................................... SUCCESS [3:03.179s] > [INFO] Lens Examples ..................................... SUCCESS [1.302s] > [INFO] Lens Distribution ................................. SUCCESS [7.318s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.526s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.042s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
