----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29919/#review68225 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/29919/#comment112369> Why is setter required for orderbyAST? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/29919/#comment112370> Can you add comment for why Setter for groupbyAST, also? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/29919/#comment112371> Why reverse? Can you add it in a comment in code? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/29919/#comment112372> Move it util and add javadoc? Also include a test in util - Amareshwari Sriramadasu On Jan. 15, 2015, 7:54 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29919/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 7:54 a.m.) > > > Review request for lens. > > > Bugs: LENS-149 > https://issues.apache.org/jira/browse/LENS-149 > > > Repository: lens > > > Description > ------- > > 1. In the json output, showing error -> list of facts instead of list of fact > -> error. Many facts have same error, makes the error a bit compact. > 2. converting getters/setters to annotations. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 33a4a7c7357206d48dbc8c91360eb57851f9572d > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > b346da6f2a0d18eb11a04a4c4e88d85ba4c2bff9 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 4d472acfe2d0d0ef5d505bffc87c1261af76decc > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 4a03701c73125a14f72378ab84234ad6563e6db8 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 5643b361bc0fdd4571ad7ac1c628ce301b552cf3 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 0bcc55855e11d2ce55ff73ee10674f9664dcc484 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java > 6074952ec2d2d49d24dd227186f4213ddba2ad86 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 06550b81988aa5cee06c86c9725770cadee58b3e > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > d2da97d3ad8d20690ff0d2e03d0ff860f6b70c90 > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > c282b3dbc8b85209d0f9f61ec7dafeba0065816b > > Diff: https://reviews.apache.org/r/29919/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
