[
https://issues.apache.org/jira/browse/LENS-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283482#comment-14283482
]
Amareshwari Sriramadasu commented on LENS-205:
----------------------------------------------
Above order, clubbing and Separation look fine to me.
* Can we enable that on checkstyle?
* Needs to be documented on contributor guide.
* We should provide formatters for popular IDEs in contributor guide in the
long run (Not required in this jira).
Are we going to reject patches which don't adhere to above? We can once we have
all the source fixed wrt to the same.
bq. Clubbing: convert to * if 5 imports are present. Just the default setting
of Idea, didn't do any changes. The number is 3 for static imports
With new import is getting added, contributor needs to remember this when to
club and when to not. This becomes huge ask from both code and review, unless
checkstyle can enforce and fail.
> Import issues in patches
> ------------------------
>
> Key: LENS-205
> URL: https://issues.apache.org/jira/browse/LENS-205
> Project: Apache Lens
> Issue Type: Task
> Components: docs
> Reporter: Amareshwari Sriramadasu
> Fix For: 2.0
>
>
> We are seeing following issues in patches :
> * The imports being changed from \* to expanded import and vice versa from
> many contributors
> * The ordering of groups being changed - alphabetical order to some other
> we need to put any hard rules around it right now, which causing this to and
> fro across multiple patches.
> This jira is to decide on when should use * vs expanded import and when
> should we convert an expanded import to *.
> Also the order of imports and document the same in contributor guide
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
