-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30159/
-----------------------------------------------------------

(Updated Jan. 22, 2015, 10:06 a.m.)


Review request for lens and Jaideep dhok.


Changes
-------

Fixes review comments, all test dependecies and test failures


Bugs: LENS-223
    https://issues.apache.org/jira/browse/LENS-223


Repository: lens


Description
-------

Changes include :
* Makes the lens-server tests run with two drivers
* Fixes createResourceQuery to properly create query context
* Cleaned up QueryContext constructors - Now there are only two constructors - 
one passing query, other passing PreparedQueryContext. 
* Added utility createContextWithSingleDriver for creating context with single 
driver - used in resource query, explain query and tests


Diffs (updated)
-----

  lens-cli/pom.xml 97fa433 
  lens-client/pom.xml fa771e4 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
64bc281 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
c63a256 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
1b4982a 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 
7534d89 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
e1988d4 
  
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java
 bc480ec 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 0971f86 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 abaa5f0 
  lens-server/pom.xml 10accd9 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 c95a948 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f964037 
  lens-server/src/test/resources/jdbcdriver-site.xml PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml ebf4ddb 

Diff: https://reviews.apache.org/r/30159/diff/


Testing (updated)
-------

TestSessionResource passes with changes, was failing without fix when running 
with two drivers. All tests pass with latest

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.492s]
[INFO] Lens .............................................. SUCCESS [1.853s]
[INFO] Lens API .......................................... SUCCESS [6.431s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.133s]
[INFO] Lens Cube ......................................... SUCCESS [7:14.549s]
[INFO] Lens DB storage ................................... SUCCESS [11.782s]
[INFO] Lens Query Library ................................ SUCCESS [5.672s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:17.076s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.583s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [29.501s]
[INFO] Lens Server ....................................... SUCCESS [5:14.872s]
[INFO] Lens client ....................................... SUCCESS [27.921s]
[INFO] Lens CLI .......................................... SUCCESS [2:00.760s]
[INFO] Lens Examples ..................................... SUCCESS [1.156s]
[INFO] Lens Distribution ................................. SUCCESS [4.223s]
[INFO] Lens Client Distribution .......................... SUCCESS [8.206s]
[INFO] Lens ML Lib ....................................... SUCCESS [52.684s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:30.962s
[INFO] Finished at: Thu Jan 22 10:06:29 UTC 2015
[INFO] Final Memory: 110M/1284M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu

Reply via email to