----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30163/#review69369 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java <https://reviews.apache.org/r/30163/#comment114065> Do we need a copy of allPaths here? Or Is it already taken care? Can you check? lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java <https://reviews.apache.org/r/30163/#comment114066> Can you add info log for 'Removing join paths' ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/30163/#comment114064> Can you remove this? Have put it in my other patch. Would conflict. - Amareshwari Sriramadasu On Jan. 23, 2015, 8:02 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30163/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 8:02 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-226 > https://issues.apache.org/jira/browse/LENS-226 > > > Repository: lens > > > Description > ------- > > 1. added pruning code > 2. test cases > 3. some cleanup, as usual ;) > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/Aliased.java > 47b4ba86da887d0abbcfdabdc572785e4771f538 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 5643b361bc0fdd4571ad7ac1c628ce301b552cf3 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 0bcc55855e11d2ce55ff73ee10674f9664dcc484 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 18154cf5ce86fe5924fdb15416bcda617dbe7a1f > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 42d5a70e1f09289ad1c8ee5e4328e8a5d23c3a28 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c95a948d6d3163a2726d4c4ce68d52fb301fad6a > > Diff: https://reviews.apache.org/r/30163/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.793s] > [INFO] Lens .............................................. SUCCESS [2.769s] > [INFO] Lens API .......................................... SUCCESS [7.572s] > [INFO] Lens API for server and extensions ................ SUCCESS [8.832s] > [INFO] Lens Cube ......................................... SUCCESS [7:02.388s] > [INFO] Lens DB storage ................................... SUCCESS [15.066s] > [INFO] Lens Query Library ................................ SUCCESS [6.467s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:16.923s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.456s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [29.466s] > [INFO] Lens Server ....................................... SUCCESS [5:00.804s] > [INFO] Lens client ....................................... SUCCESS [22.296s] > [INFO] Lens CLI .......................................... SUCCESS [1:59.430s] > [INFO] Lens Examples ..................................... SUCCESS [1.083s] > [INFO] Lens Distribution ................................. SUCCESS [4.592s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.680s] > [INFO] Lens ML Lib ....................................... SUCCESS [47.880s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:01.899s > [INFO] Finished at: Fri Jan 23 08:01:28 UTC 2015 > [INFO] Final Memory: 114M/1313M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
