----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review69560 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java <https://reviews.apache.org/r/30250/#comment114259> should be abstract? lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java <https://reviews.apache.org/r/30250/#comment114265> What is this id for? lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java <https://reviews.apache.org/r/30250/#comment114266> Why is this constructor required? lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java <https://reviews.apache.org/r/30250/#comment114267> Can you use toString from lombok itslef? lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java <https://reviews.apache.org/r/30250/#comment114268> SessionEvent already has user. Why is this required here? May be we should only have it here and remove from SessionEvent lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java <https://reviews.apache.org/r/30250/#comment114269> Should this different from SessionClosed event? or Should extend SessionClosed ? We should also add metrics - counters for how sessions opened, closed and gauge for current open sessions. Can be part of this jira or a separate jira is fine too. - Amareshwari Sriramadasu On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 8:56 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c95a948 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7641232 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > 0db5c02 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
