-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30253/
-----------------------------------------------------------

Review request for lens, Jaideep dhok and Jothi Padmanabhan.


Bugs: LENS-236
    https://issues.apache.org/jira/browse/LENS-236


Repository: lens


Description
-------

Main changes include :

* Adding comments in cube xsd
* Separated XCube as abstract class , and derived classes for XBaseCube and 
XDerivedCube
* Remove unnecessary collection types
* Enumeration added for column types, measure types and update periods
* JoinChain definition changed to Paths consisting of edges, where each edge 
has pair of references
* Made storage table elements part of fact table and dimension table defintion. 
Removed confusing Update_period_element after that.
* Moved table_name to flattedcolumn it self and removed from 
measure/expression/attribute definition

Still TODO :
* Fix skewed info definition
* Update java client and examples to use changed xsd definition


Diffs
-----

  lens-api/src/main/resources/cube-0.1.xsd f75ea60 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
42f5e0a 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 59c3727 
  
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
 1acab08 
  
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 9ef89f6 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
2a9566f 
  
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
 7194f6c 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 
808f7e6 
  
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
 8bf9f81 

Diff: https://reviews.apache.org/r/30253/diff/


Testing
-------

TestMetastoreService passes with changes


Thanks,

Amareshwari Sriramadasu

Reply via email to