[ 
https://issues.apache.org/jira/browse/LENS-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291082#comment-14291082
 ] 

Amareshwari Sriramadasu commented on LENS-236:
----------------------------------------------

[~jothi], Please have look at https://reviews.apache.org/r/30253/. If you want 
to look at updated xsd, directly see here - 
https://github.com/Amareshwari/incubator-lens/blob/LENS-236/lens-api/src/main/resources/cube-0.1.xsd

bq. Add comments
bq. Remove weight in cube and dimension
bq. Is both derived and parent needed?
bq. Remove cube_table from measure, expr_column
bq. Remove cost from measure, dim_attribute
bq. Should the type of measure be a list of allowable types instead of string
bq. dimension_table, change dim_table to dimension
bq. enumeration for update_periods
bq. x_storage_elements description change
bq. x_dim_attributes, dim_attr_names --> min_occurs should be 1

Done.

bq. x_dim_attribute --> do we need table_ref, wont chain_ref alone suffice?
Made it choice. We might want to give simple references for single hop and 
single paths - no chains might be required for those.
bq. x_parition, change cube_table_name
Haven't changed. This should be name of fact table or dimension table to which 
partition is getting added. Whats a good name - shall i make factOrDimTableName 
?

bq. Please check if x_partition should expose more parameters
Checked this. This is inline with AddPartitionDesc in Hive, so havent done any 
changes. 

> Cube.xsd cleanup
> ----------------
>
>                 Key: LENS-236
>                 URL: https://issues.apache.org/jira/browse/LENS-236
>             Project: Apache Lens
>          Issue Type: Bug
>            Reporter: Jothi Padmanabhan
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 2.0
>
>
> # Add comments
> # Remove weight in cube and dimension
> # Is both derived and parent needed?
> # Remove cube_table from measure, expr_column
> # Remove cost from measure, dim_attribute
> # Should the type of measure be a list of allowable types instead of string
> # x_dim_attribute --> do we need table_ref, wont chain_ref alone suffice?
> # x_dim_attributes, dim_attr_names --> min_occurs should be 1
> # dimension_table, change dim_table to dimension
> # enumeration for update_periods
> # x_storage_elements description change
> # x_parition, change cube_table_name
> # Please check if x_partition should expose more parameters
> Detailed description on update_period_elements and sample usage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to