----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30242/#review69581 -----------------------------------------------------------
Ship it! Looks good. I am assuming you will create appropriate entries in LICENSE file for the ones that doesn't include license as part of LENS-220. Thanks - Srikanth Sundarrajan On Jan. 24, 2015, 3:09 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30242/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2015, 3:09 a.m.) > > > Review request for lens and Srikanth Sundarrajan. > > > Bugs: LENS-230 > https://issues.apache.org/jira/browse/LENS-230 > > > Repository: lens > > > Description > ------- > > Main changes include : > * Rename all *.txt data files as *.data > * Remove headers for js files that are copied > * Add headers for .gitignore and control files > * Rename all*.txt query files as *.sql and add headers > > Now the rat exclusion looks the following : > > <excludes> > <exclude>README.*</exclude> > <!-- Local git repo --> > <exclude>.git/**</exclude> > <!-- For connecting to ReviewBoard thru rbt tools--> > <exclude>.reviewboardrc</exclude> > <!-- IDE files --> > <exclude>.idea/**</exclude> > <exclude>**/*.iml</exclude> > <exclude>**/.classpath</exclude> > <exclude>**/.project</exclude> > <exclude>**/.checkstyle</exclude> > <exclude>**/.settings/**</exclude> > <exclude>**/maven-eclipse.xml</exclude> > <exclude>**/.externalToolBuilders/**</exclude> > <!-- Build directories - target for maven build/ for other tools > like sloccount --> > <exclude>**/target/**</exclude> > <exclude>**/build/**</exclude> > <!-- To make developer life easy. Source wont have these files --> > <exclude>**/*.diff</exclude> > <exclude>*.patch</exclude> > <exclude>**/*.log</exclude> > <!-- .png files constitute images required for documentation. > .pptx contain the sources for images --> > <exclude>**/*.png</exclude> > <exclude>**/*.pptx</exclude> > <!-- .data files are used to hold data for loading into tables - > used in tests and examples --> > <exclude>**/*.data</exclude> > <!-- Used on ui --> > <exclude>**/codemirror.min.*</exclude> > <exclude>**/*.js</exclude> > </excludes> > > > Diffs > ----- > > .gitignore 86109a2 > checkstyle/src/main/resources/suppressions.xml 6a30a76 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > d75cadf > lens-cli/src/test/resources/data.data PRE-CREATION > lens-cli/src/test/resources/data.txt 6c99c9a > lens-client-dist/src/deb/client/control 75aa60a > lens-client-dist/src/main/assembly/client-dist.xml 8190720 > lens-dist/src/deb/control/control 9b0b028 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 648d227 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 26202d7 > lens-driver-hive/src/test/resources/priority_tests.data PRE-CREATION > lens-driver-hive/src/test/resources/priority_tests.txt 230df95 > lens-driver-hive/testdata/testdata1.data PRE-CREATION > lens-driver-hive/testdata/testdata1.txt da9dfd0 > lens-driver-hive/testdata/testdata2.data PRE-CREATION > lens-driver-hive/testdata/testdata2.txt f251809 > lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java > 1f7635e > lens-examples/src/main/resources/cube-queries.sql PRE-CREATION > lens-examples/src/main/resources/cube-queries.txt 43b2d06 > lens-examples/src/main/resources/dimension-queries.sql PRE-CREATION > lens-examples/src/main/resources/dimension-queries.txt 65e93cf > lens-server/src/main/webapp/static/css/codemirror.min.css 6d0eaec > lens-server/src/main/webapp/static/js/libs/codemirror.min.js 14cd78e > lens-server/src/main/webapp/static/js/libs/jquery.flot.js 8403347 > lens-server/src/main/webapp/static/js/libs/moment.js 6ae61a1 > lens-server/src/main/webapp/static/js/libs/sql.js 27ab466 > lens-server/src/main/webapp/static/js/libs/stupidtable.min.js c84a720 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 8b156f8 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > a886c85 > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > f09a876 > > lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java > ce105de > lens-server/src/test/resources/user/propertybased.data PRE-CREATION > lens-server/src/test/resources/user/propertybased.txt 0b04da0 > lens-server/testdata/testdata2.data PRE-CREATION > lens-server/testdata/testdata2.txt 4d0bfcb > pom.xml bc7e92a > > Diff: https://reviews.apache.org/r/30242/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.539s] > [INFO] Lens .............................................. SUCCESS [1.829s] > [INFO] Lens API .......................................... SUCCESS [7.489s] > [INFO] Lens API for server and extensions ................ SUCCESS [7.213s] > [INFO] Lens Cube ......................................... SUCCESS [6:57.041s] > [INFO] Lens DB storage ................................... SUCCESS [11.960s] > [INFO] Lens Query Library ................................ SUCCESS [6.319s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:10.747s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.413s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [28.359s] > [INFO] Lens Server ....................................... SUCCESS [5:10.657s] > [INFO] Lens client ....................................... SUCCESS [21.688s] > [INFO] Lens CLI .......................................... SUCCESS [2:03.190s] > [INFO] Lens Examples ..................................... SUCCESS [1.214s] > [INFO] Lens Distribution ................................. SUCCESS [4.499s] > [INFO] Lens Client Distribution .......................... SUCCESS [8.500s] > [INFO] Lens ML Lib ....................................... SUCCESS [49.245s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:57.076s > [INFO] Finished at: Sat Jan 24 02:58:05 UTC 2015 > [INFO] Final Memory: 112M/1290M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
