----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30444/#review70325 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java <https://reviews.apache.org/r/30444/#comment115437> typo? `addAllMeasuresToFlattenedList`? Rest all good. Please update test results. - Rajat Khandelwal On Jan. 30, 2015, 6:33 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30444/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 6:33 a.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-58 > https://issues.apache.org/jira/browse/LENS-58 > > > Repository: lens > > > Description > ------- > > Changes include : > * Flattened columns include reachable fields through join chains, not through > references > * Includes destination table for x_chain_column and x_join_chain in xsd to > make user know the destination table of the chain directly, instead of > looking up chain. > * Moved table_name to flattedcolumn it self and removed from > measure/expression/attribute definition. The changes are picked directly > picked from LENS-236 to avoid conflicts. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f75ea60 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 9ef89f6 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 2a9566f > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7194f6c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 8bf9f81 > > Diff: https://reviews.apache.org/r/30444/diff/ > > > Testing > ------- > > TestMetastoreService passes. Will update full test result. > > > Thanks, > > Amareshwari Sriramadasu > >
