----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30494/#review70574 -----------------------------------------------------------
Can you close this as discarded in favor of https://reviews.apache.org/r/30497/ ? - Amareshwari Sriramadasu On Feb. 2, 2015, 11:26 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30494/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 11:26 a.m.) > > > Review request for lens. > > > Bugs: LENS-247 > https://issues.apache.org/jira/browse/LENS-247 > > > Repository: lens > > > Description > ------- > > Checkstyle changes for lens-cli, lens-client and lens-examples > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle.xml > e519a60fca323cfaaeec6a675969a7f490330778 > lens-cli/pom.xml d7e46de7b9dcb1ccc4ebdf20abadfc69aaab10d9 > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 9ae69bd1f7b64229048bbdbf920d77f9ea319e18 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 3b319f15e6b0360d86cff71759f20db5290ed683 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > e9c3904d80658f813441d984d50b0581f9ded3a1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > 30712c45885b3c69ef25d5302587e82504703ab8 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > 201b1ee3a1cadf05c66951892e1a895cf327cb03 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > f8833be8ba69d77631fc65cd30dc71616383b94c > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > eb966ed2814410bf1dd0c05dd96f826dfde1ec0c > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java > 9bfb67d5fbdf8298593923a99d27a1a22c13167f > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 9b07a3b40572519519cf71937add908456c42e55 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 15111d3412d35975612de61763ae12656fa28f14 > lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml > 24a35fd5fd66d10357f31de7da6478813638bba9 > lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java > b98a719596feda48b2189093b362bc27b2383912 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 15cc6bc5068cb87d68e6f6a935da33b12c4e47d1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 9cc2ba1002fe18beaf05e9c22bfb97cc873ff20b > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > f43f53c807d0e726938d3fc3f37fab2adbb021b6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 6e6f9d2c4b9cfd200fc7544f1152beac97c925e7 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 6f822b9c29ae8b7a39544e6b9597a123c618d89d > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > d3d16ec03a5eec1a0610c52654984dfc7d78a4c0 > lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java > ed4866fc64c8ce94112c8b1a3d0505fe37650dc9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 95546737e8c54ffc3256433b45b760537c60a3c6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 0626618f8491ab2c8edf99b9654033e69507d329 > lens-cli/src/test/resources/dim-local-storage-element.xml > 4688383fa4ae8696616b27d3110b87f290895f4e > lens-cli/src/test/resources/dim1-local-part.xml > 4c541ee85aed7c68c39604055fea61976665fb08 > lens-cli/src/test/resources/dim_table.xml > 3005049d201a185c3903bcedb3c6ffda4a0baa60 > lens-cli/src/test/resources/dim_table2.xml > 617fa750899f6bd4e5ba5afa3b92bf1e12b6c711 > lens-cli/src/test/resources/fact-local-storage-element.xml > 7561f38251e740a025025970adeb05ffa1c32a54 > lens-cli/src/test/resources/fact1-local-part.xml > 43ddc62696039eb5a6d9964d6a9018428f2a015d > lens-cli/src/test/resources/fact1.xml > c47182609b43a9d227a3cfff63bac1c6e5b5bf6e > lens-cli/src/test/resources/local-storage.xml > 32ed32b9bd73db5b072eee196a5cd5fccf9b11f7 > lens-cli/src/test/resources/sample-cube.xml > 2ba17fc4385b41d77c3b8fa6989261a17e65f9b0 > lens-cli/src/test/resources/test-dimension.xml > 70bcd091b0e91fcaaa6d8453c67c204194d4fdab > lens-client/pom.xml 2a20596611431f43961c2cffce3e42a1f55904ed > lens-client/src/main/java/org/apache/lens/client/Credentials.java > e92783f45420d0c43f5c09a418ed7cf4032d055d > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 98b22b3cc693c863df7f6dfed297f11727a707aa > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > a4207271e94ee4e1fe9c262082e9eacf51c2b8c1 > lens-client/src/main/java/org/apache/lens/client/LensClientResultSet.java > af0897b4bf8f917a40d87627c80b0d421ed3c679 > > lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java > 9bcd8d5f457e6d3ae9bd37d0eacb99a7374d7ef2 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 32a146a22f0393635a78f616b48c5378f35e81d7 > lens-client/src/main/java/org/apache/lens/client/LensConnectionBuilder.java > 5740e78c2eca3bd5f95e5c7b4fd274ace0369740 > lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java > 777a0154d8e36e49f8898795deea29d2f444db61 > lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java > 11f68930fb94b8bedfb1289b84d215ea6f23b18f > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > 085de476c663172a4153a3f8330b121edca1e008 > > lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientException.java > 054801504a28ff62246fd9a019a77def241e76d4 > > lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientServerConnectionException.java > ec5fe7d1dfb88668a77e9b827d482d05529638dc > lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java > 56e861aef1b29ee9941f1c068269303eb22454be > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcConnection.java > a45d2266cf3cf9eaa289e7cb9df21ace0cadc7dc > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java > beadb0ef6cffb64df0879ff79aedc567e239b8a8 > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcResultSet.java > 6828fa435c6e4b1f99963968302a17803743d383 > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcResultSetMetadata.java > 68a9fd8a90383fd1ef0ab27ceea097900d8564ec > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcStatement.java > 8a024e93c9b659d2386665fb1d8847d8df27dbb9 > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 213e46e91a528184019f836ad5e40d0cdd9f99e4 > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java > 0bde100cdf29d83a4e7782bc31b40086012d85d5 > lens-examples/pom.xml 4fa4f054aefda99028e6c64b88f6f0c39cf38c4e > lens-examples/src/main/java/org/apache/lens/examples/DatabaseUtil.java > 8379ffec774ea80fb4dd3368dd7c6b94c7ad0611 > > lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java > 01e83d24ff7f2d49839bc496f6208a5bcf18fd51 > lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java > 06a5e0489c3753381df4e57f51f7ec50d4986b71 > lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java > 5cea3477e0bf5a175cc12ec7b4e264f952bbb4a0 > lens-examples/src/main/resources/db-storage.xml > cfa54b211d5a1e27199c7d2e2440a4b029795e17 > lens-examples/src/main/resources/dim1-local-part.xml > 961a13789334e612f25d8dbf91b2be7130e69950 > lens-examples/src/main/resources/dim2-local-part.xml > 31bdd7efbcecef558f92a2fbabbc92d524d6bf77 > lens-examples/src/main/resources/dim4-local-part.xml > 0a45d16924fcc22b96fa2402b304e08bb6532be8 > lens-examples/src/main/resources/dim_table.xml > ea3ceccdd797890b8b5d0488b09d7961392d0f41 > lens-examples/src/main/resources/dim_table2.xml > 25ca90aa7214482a6222fe6b1c68cdad68b6c157 > lens-examples/src/main/resources/dim_table3.xml > d4312ba2b68196bf5bff97195aaff9b80b97995a > lens-examples/src/main/resources/dim_table4.xml > 357a10f4b8da8cc542b38f486f2d54d04715869f > lens-examples/src/main/resources/fact1-local-part1.xml > 2ebec0ef21bad4a16e0e0519956a0dc81a47f499 > lens-examples/src/main/resources/fact1-local-part2.xml > cd10274e6b9bf9f10b40ed298dba1774329a8c88 > lens-examples/src/main/resources/fact1-local-part3.xml > 864d564928fa1e3b10cda34f1f0a35c134a7f106 > lens-examples/src/main/resources/fact1.xml > 2f5629389544bc59de913ec609028b0e4353e62b > lens-examples/src/main/resources/fact2-local-part1.xml > 712f29a502cc249e501d29f465b3d83e1d333f1c > lens-examples/src/main/resources/fact2-local-part2.xml > 5dd6fbcd3a77d55e3016d7ddaecae1b73ce9c96f > lens-examples/src/main/resources/fact2-local-part3.xml > c58bc35a251d8b36d2052c80865f30adb4ee6c5b > lens-examples/src/main/resources/fact2.xml > cb2b3f6f27858b59087564f00978eb630b9b77bd > lens-examples/src/main/resources/local-cluster-storage.xml > 731b554ae2d4c077e2a51cddc516d8c062cd89c3 > lens-examples/src/main/resources/local-storage.xml > dd82c65e221945bca9d7f960ad43bd3d0b977036 > lens-examples/src/main/resources/raw-local-part1.xml > 336f834eda69b9048a55a9d87b22b200c4eec5d9 > lens-examples/src/main/resources/raw-local-part2.xml > 473b3792e3986da47285036e69c4c7a6b9fb4870 > lens-examples/src/main/resources/raw-local-part3.xml > c44c17f16b10384ffc12ca316970d50fead32c12 > lens-examples/src/main/resources/raw-local-part4.xml > c403be54bc6917e2f7ba36c26875414a1c380df4 > lens-examples/src/main/resources/raw-local-part5.xml > d5172f14ab0ca5484f45521935289e4ab4695f3d > lens-examples/src/main/resources/raw-local-part6.xml > ed607cf5c45bdc13288fbf1e48cbbd5d177271c5 > lens-examples/src/main/resources/rawfact.xml > 51b4eb211f1906ace47a7a58fe9b9d1948b1c339 > lens-examples/src/main/resources/sample-cube.xml > ed0d6cd3278a2e21bc1062dd42e60a78606c2f93 > lens-examples/src/main/resources/sample-db-only-dimension.xml > 4bf5ffa30fa00540a7165007c36035bc5dd6d559 > lens-examples/src/main/resources/sample-dimension.xml > 7f650fcc6bb9a0cc5fa94f7bbfb9dd4d57177efd > lens-examples/src/main/resources/sample-dimension2.xml > 3ae8797028a37b9b1dbc595fb30f8d66e05a4e1c > > Diff: https://reviews.apache.org/r/30494/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
