-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30556/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 12:10 p.m.)
Review request for lens.
Bugs: LENS-50
https://issues.apache.org/jira/browse/LENS-50
Repository: lens
Description
-------
draft
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml
bffad97e74f762cd3147911621036d885101576f
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java
8db86b7cbbf70c1f289a4b68d2949019db8b890d
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
a354e3cea1838c9015a94e078b91f7b84d15c18e
lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java
2c0e70d006eab1d301bd43a456881a0e23bb06f8
lens-cube/src/main/java/org/apache/lens/cube/metadata/ColumnMeasure.java
18d4a1bc7b8a5aace67f97b217b4df72009730d5
lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java
8afdc7b0c12e388d633cc364f96f743dabd7e5fe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimAttribute.java
550f61008840862ccda19b4205e8ca56de46650f
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java
76328121acb18744594be5f4337b7b9cde1a32ce
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java
ce20f24f4cc7e23123c82c2b0eacbdff6688c6bd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java
7389b4ca5419813c84f44a7c2adb09db1d331544
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMeasure.java
7eddadf3856f662b56bdb755ffc3f2c6c790db99
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
7c5879a21324f9b652f63b5145699603bcc19b83
lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java
cbb2f81f3dd8ad62612b0e02333ca335da488605
lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java
ff6460fce1052bcfabd6dd7064c733c0ddc0d314
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java
00452bace13d82b54ce2d1e4dc99dd11af98b768
lens-cube/src/main/java/org/apache/lens/cube/metadata/HierarchicalDimAttribute.java
8ee54d69b64f6e420236dfa1f32a5a99610a3d30
lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java
140f284c0e753b938d65e4ae0bf846bb31554ffe
lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java
527f21c6240d0d928b4cd0f4a841d1977457cf29
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java
6b81cae98c67d1eb7ffa682f10abad1882ab8de4
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java
4f283ad36f50288e41bb4df7a72795bdd9f842f4
lens-cube/src/main/java/org/apache/lens/cube/metadata/Named.java
71b9d26cb01ec04035021e76d99b2c38ddda7574
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java
06d900514aac5fbdbc998fd0fae810acef0fba1c
lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
ab06db93097676b45f40b6dfd3542db08d0f0876
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java
f0e14b241be8a56ab3e94b970b398d2056041362
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java
0a6f489948c5c19440598cc19d03d34a9eba9d4f
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java
a67bf1e86b7e1bf9cdb955c6cb06d18db1999a8e
lens-cube/src/main/java/org/apache/lens/cube/metadata/StoragePartitionDesc.java
111e75a8c8e1567dbf09553f6f14099edfcc9f75
lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageTableDesc.java
9be7d53fa5b9947d63fb5a5900dde19c60eafc76
lens-cube/src/main/java/org/apache/lens/cube/metadata/TableReference.java
7f2dc6d960f0b89ef08dc195b1893139d7d9e83b
lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java
88a8a577fb46d9a303986d4129a667463e5325fa
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
154aa0243f3ff273f631592630c2b51ab5db396f
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java
5b17a3cdc13a5726d5b825b3e028f8eecb9abdd3
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java
85b3eeef1f890017d9d59d1ad57a5427ee601ab6
lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
ec0b948a9fefa4f92b1605fb5b70217831eb5169
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java
cf517df396edfb6e28dfee4b3b964dce05f656b3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java
bec55f5be897b7a2b39c6f816c8ad0fa3999e984
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java
73a2205c74577a50541062b74c6de1036c51a319
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
106cad0218d599186715d06c9c046e2d4203f016
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
4c5cf2f2688d309e012453a49e08b1a23a5df9a3
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java
f8a71bc726dffe07215445d479e2b75ee0938a96
lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java
64a52ff96f56ab4f7bf2034c192c5724bd67dd4e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java
f5057f49e926997d2d3f2d0b2d0d798a1fb132df
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
11ae7ed2b6e72534f31905a107a777a53508d533
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
1325c050750dc00940e30fa2dd0c3ed745215e0a
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java
1589857f6a392acb351e0b889826abb388e4ae31
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java
0168f4acb4ad7ed2441607c47b1447548882240f
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
4c9189e6206667e56b4210d83dbfb41e4f2cb1dd
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java
15891c8d75ddb901608a8c95bc255ecbc7fc02f3
lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java
8d6274ceea766f96e2abf330db2b6ee8eb89e213
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
f604d0ceaa08836f1054b12070317213f3238ce7
lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java
2bb32333d55ab8cb982d96ffef9799785c8f7dd3
lens-cube/src/main/java/org/apache/lens/cube/parse/FactPartition.java
cc1992315256fa061fc37806f0b2b0302f302132
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
1021c964854f311966c689b5c0eec0d9c9962c33
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java
fb196cc2b282d3e87401d61fbfa6b25c013bce0d
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
d31dddcf8bad4d2cee6d05bc07375e5b2bff4b79
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java
d864d8f701f191882995aa8cc94463e814e133f8
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
1abb243daec5219f511a8d29817ec629d0d370e4
lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java
426fe6dfa3b574abb78b45415cde4f2f47dcb60f
lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java
92169983d6b8fdc7f792b2b692b9c6a4081989bc
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java
7afe82ece61a9fc3ca6bf263439a127e64442567
lens-cube/src/main/java/org/apache/lens/cube/parse/ORTimeRangeWriter.java
4893b77528540fd858c8a74f29f4be1bab131cd5
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java
2bc3721c009a8fd17fa6074eeeb6499cb37626e7
lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java
f067d0a2ede455c8d90dbb87dcb7b35f6469150a
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java
3a5f296c3da86fe458f93eb9bea4b5e8e44bc495
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
6381ba31eeb599b15e02438ecbb5d040d166f45b
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java
6d724ea3487c95cef91e0b95a2f9d77c6dc741ea
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeUtils.java
8e9ac1337dfdb997d3746edb44a32a1c51637b99
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java
4ac2151bcd3eb70958ecf992245d5ffa6cde25ef
lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java
43dece3382b32b57b85df0d72ab3e6b601a7c3a6
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java
16b18cfef84305f76d89bac034a1699d9d82c5e8
lens-cube/src/main/resources/olap-query-conf.xml
b20407894420a84296f7e94cbc39d0973cf5ac4d
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
f9e9f3d4103c3ad982abced549ae5f27779289c1
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java
f21361e5d91863b5970197ce3e77c9e04bba0527
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestMetastoreUtil.java
73d2c166a742d8bc0496d0fbbc49069345d486ce
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
da9e778a6c35c21e12ed75ffb5a99dd04c572fa7
lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java
36c813489e85045874763a133b7b3895ec130aec
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
5d234a38af3f208b8d3339a32d46713f2f06fe9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
3f86b77fc426929969d209727ec2474119e0a7ce
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
3b0212242088b089b0aeaad8c3f744eb379e95b2
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
22f9eba3dca5c3489faa5cb413b606d8490408c6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
fe679a9802dc31df2eaafdc69a1baf1f7dca4aa8
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
75cb0aa250e902ed3e2a0b091230e26de6a41816
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
fcb973c994f840ce730821e03dc3562896955b38
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
d11b7f26b4e825b2f54a798a78ccb26df1ba723b
lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java
dc76b587b800182e5acd03e35dc00a682825fd95
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java
a7fdb59faf47e8ef914be03cb2ebc4ac6be959fa
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java
9e9d7ec1b5865c4d78cb8a9d3abb85e75297509b
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
f68715f9f0c6461e722bbc60d756d2fe71503947
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
cce79059e81c07c52fd1ffec6d079872d1455e8a
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
3b93a6b22d1c18f1c49598cd3eecc78d76bc929d
lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java
30ede106395c931f6fd7a626b1604ec88f132b76
lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java
6a6272838684c5dc372514813a23127d49b6eb27
lens-cube/src/test/resources/hive-site.xml
b450ec28f89ca17bf27663b29bafcab17744f912
Diff: https://reviews.apache.org/r/30556/diff/
Testing
-------
[INFO] Starting audit...
AbstractBaseTable.java:121:3: Definition of 'equals()' without corresponding
definition of 'hashCode()'.
ColumnMeasure.java:36:10: More than 7 parameters.
ColumnMeasure.java:41:10: More than 7 parameters.
Cube.java:176:3: Definition of 'equals()' without corresponding definition of
'hashCode()'.
CubeDimensionTable.java:131:3: Definition of 'equals()' without corresponding
definition of 'hashCode()'.
CubeFactTable.java:107:3: Definition of 'equals()' without corresponding
definition of 'hashCode()'.
CubeMeasure.java:35:13: More than 7 parameters.
DerivedCube.java:137:3: Definition of 'equals()' without corresponding
definition of 'hashCode()'.
Dimension.java:140:3: Definition of 'equals()' without corresponding definition
of 'hashCode()'.
CandidateTablePruneCause.java:52:1: Utility classes should not have a public or
default constructor.
DimHQLContext.java:52:3: More than 7 parameters.
JoinResolver.java:331:12: More than 7 parameters.
StorageTableResolver.java:425:19: More than 7 parameters.
CubeTestSetup.java:243:24: More than 7 parameters.
Audit done.
Thanks,
Rajat Khandelwal
