----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30663/#review71283 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java <https://reviews.apache.org/r/30663/#comment116956> If we create a separate test method (say testDoNotAcceptQueryWithSameFromAndToDate()), will it help in creating test cases more modular and intuitive ? - Himanshu Gahlaut On Feb. 5, 2015, 12:20 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30663/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 12:20 p.m.) > > > Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, > Srikanth Sundarrajan, and Suma Shivaprasad. > > > Bugs: LENS-269 > https://issues.apache.org/jira/browse/LENS-269 > > > Repository: lens > > > Description > ------- > > Trivial fix > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 4c24214 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java > c9fb234 > > Diff: https://reviews.apache.org/r/30663/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.161s] > [INFO] Lens .............................................. SUCCESS [1.793s] > [INFO] Lens API .......................................... SUCCESS [4.900s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.185s] > [INFO] Lens Cube ......................................... SUCCESS [6:19.755s] > [INFO] Lens DB storage ................................... SUCCESS [9.943s] > [INFO] Lens Query Library ................................ SUCCESS [4.713s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:43.772s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [23.988s] > [INFO] Lens Server ....................................... SUCCESS [4:24.293s] > [INFO] Lens client ....................................... SUCCESS [21.683s] > [INFO] Lens CLI .......................................... SUCCESS [1:45.350s] > [INFO] Lens Examples ..................................... SUCCESS [0.792s] > [INFO] Lens Distribution ................................. SUCCESS [3.624s] > [INFO] Lens Client Distribution .......................... SUCCESS [5.630s] > [INFO] Lens ML Lib ....................................... SUCCESS [41.012s] > [INFO] Lens Regression ................................... SUCCESS [0.767s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:20.246s > [INFO] Finished at: Thu Feb 05 11:39:28 UTC 2015 > [INFO] Final Memory: 99M/1038M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
