On Feb. 6, 2015, 4:10 a.m., Himanshu Gahlaut wrote: > > Can you update testing done? > > > > Can we add a unit test to check if buffer size config is getting honoured?
Testing done is already updated. Any suggestions on how to write this unit test case ? - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30692/#review71368 ----------------------------------------------------------- On Feb. 5, 2015, 8:27 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30692/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 8:27 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-273: Synchronizing persistence of lens services state on lens > persistence lock. Increasing Buffer size of Lens Service Persistence output > stream to conf value (default: 1MB) from 4096 bytes > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e19d2d8393f43935216dadbe5d2f5f9da8 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > b1f087ca354db5b7ae6f3aa156c63937eaa3d057 > lens-server/src/main/resources/lensserver-default.xml > 4dddde10ef77b067cc11df4de59f030924f6d29d > > Diff: https://reviews.apache.org/r/30692/diff/ > > > Testing > ------- > > All test cases passed. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [10.050s] > [INFO] Lens .............................................. SUCCESS [9.468s] > [INFO] Lens API .......................................... SUCCESS [21.998s] > [INFO] Lens API for server and extensions ................ SUCCESS [24.143s] > [INFO] Lens Cube ......................................... SUCCESS [8:28.502s] > [INFO] Lens DB storage ................................... SUCCESS [45.739s] > [INFO] Lens Query Library ................................ SUCCESS [21.814s] > [INFO] Lens Hive Driver .................................. SUCCESS > [18:35.184s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [49.235s] > [INFO] Lens Server ....................................... SUCCESS > [20:14.519s] > [INFO] Lens client ....................................... SUCCESS [1:01.311s] > [INFO] Lens CLI .......................................... SUCCESS [6:19.398s] > [INFO] Lens Examples ..................................... SUCCESS [1.788s] > [INFO] Lens Distribution ................................. SUCCESS [6.293s] > [INFO] Lens Client Distribution .......................... SUCCESS [7.595s] > [INFO] Lens ML Lib ....................................... SUCCESS [3:00.583s] > [INFO] Lens Regression ................................... SUCCESS [0.514s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:01:00.664s > [INFO] Finished at: Fri Feb 06 01:46:27 IST 2015 > [INFO] Final Memory: 96M/329M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
