> On Feb. 4, 2015, 4:25 p.m., Amareshwari Sriramadasu wrote: > > src/site/apt/developer/contribute.apt, line 96 > > <https://reviews.apache.org/r/30608/diff/1/?file=847322#file847322line96> > > > > In contributor guide, let us point to git repo as the source sothat it > > becomes easy for contributor to contribute back his work. and move building > > from source release to quick start. Thoughts?
(1) Will add github repo link in building from source. (2) I'm assuming that meaning of quick start in the comment is getting started page under lenshome. If Yes, then that will divert us from the objective of making it difficult for non developers to reach building from source. If the comment meant something else by quick start,then I haven't understood it. Please help in understanding the same. > On Feb. 4, 2015, 4:25 p.m., Amareshwari Sriramadasu wrote: > > src/site/apt/gettingstarted/install-steps.apt, line 30 > > <https://reviews.apache.org/r/30608/diff/1/?file=847323#file847323line30> > > > > Let us mention that download contains both source release and > > convienient binary distribution. > > > > Also, I'm thinking building from source release should be here itself. If intended audience for source release is contributing developer, then shall we have all source release information only in developer doc ? > On Feb. 4, 2015, 4:25 p.m., Amareshwari Sriramadasu wrote: > > src/site/apt/gettingstarted/install-steps.apt, line 37 > > <https://reviews.apache.org/r/30608/diff/1/?file=847323#file847323line37> > > > > These steps to build from github should be moved to contributor guide Didn't get this. The steps seems to be already moved. > On Feb. 4, 2015, 4:25 p.m., Amareshwari Sriramadasu wrote: > > src/site/apt/gettingstarted/install-steps.apt, line 60 > > <https://reviews.apache.org/r/30608/diff/1/?file=847323#file847323line60> > > > > This would contain only hive source. It needs to b e built and > > HIVE_HOME should be set to packaging directory Will add steps to build from hive source here. > On Feb. 4, 2015, 4:25 p.m., Amareshwari Sriramadasu wrote: > > src/site/apt/gettingstarted/install-steps.apt, line 137 > > <https://reviews.apache.org/r/30608/diff/1/?file=847323#file847323line137> > > > > Lets leave it as Hive only. Will change to Hive. > On Feb. 4, 2015, 4:25 p.m., Amareshwari Sriramadasu wrote: > > src/site/apt/gettingstarted/install-steps.apt, line 225 > > <https://reviews.apache.org/r/30608/diff/1/?file=847323#file847323line225> > > > > bin/lens-cli.sh should work. I dont know about any start option here, > > is there such an option? Will fix this. - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30608/#review70973 ----------------------------------------------------------- On Feb. 4, 2015, 7:58 a.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30608/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 7:58 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-221: Install and Run Documentation improvement > > > Diffs > ----- > > src/site/apt/admin/deployment.apt 57be5211f080c9d931afde5c7a3c90b5b34d25c5 > src/site/apt/developer/contribute.apt > 8015d68e2bd53043b27181533aabc6ca3a3c6664 > src/site/apt/gettingstarted/install-steps.apt > ef5724de1587c214eb241ee860d9c71ed59c27a8 > src/site/apt/gettingstarted/pseudo-distributed-setup.apt > src/site/apt/gettingstarted/quick-start.apt > ec97d073a23f603c2e34f0d46c43aa73fce2f69c > src/site/site.xml f0f0a55d4e67e52eb06bdb62f1e8bc4c72b4e6e8 > > Diff: https://reviews.apache.org/r/30608/diff/ > > > Testing > ------- > > Ran site on local machine to test contents. > > > Thanks, > > Himanshu Gahlaut > >
