----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30794/#review71634 -----------------------------------------------------------
Ship it! lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30794/#comment117496> Actually, you can have this in your documentation and just present the link. - Jothi Padmanabhan On Feb. 9, 2015, 1:23 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30794/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 1:23 p.m.) > > > Review request for lens and Jothi Padmanabhan. > > > Bugs: LENS-287 > https://issues.apache.org/jira/browse/LENS-287 > > > Repository: lens > > > Description > ------- > > Changes include > > - Reverted the change with respect to enumeration of column types, as > creating complex types becoming too much verbose when putting in xml. > For example, If type map<int, arry<string>>, the same would be expressed in > the string representation. If we would like to change it xml representation, > it looks like the following : > > <type> > <map> > <keyType>int</keyType> > <valueType> > <array> > <elementType> > <primitive>string</primitive> > </elementType> > </array> > </valueType> > </map> > </type> > > So, going with string representation as per hive, than xml representation. > > - Updated test with complex type dim attribute > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 568d1c9 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > c620602 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 2fd125c > > Diff: https://reviews.apache.org/r/30794/diff/ > > > Testing > ------- > > TestMetastoreService passes. Will update result for running examples > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.313s] > [INFO] Lens .............................................. SUCCESS [1.794s] > [INFO] Lens API .......................................... SUCCESS [5.053s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.037s] > [INFO] Lens Cube ......................................... SUCCESS [6:20.370s] > [INFO] Lens DB storage ................................... SUCCESS [10.219s] > [INFO] Lens Query Library ................................ SUCCESS [4.515s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:37.082s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [24.744s] > [INFO] Lens Server ....................................... SUCCESS [4:26.809s] > [INFO] Lens client ....................................... SUCCESS [19.916s] > [INFO] Lens CLI .......................................... SUCCESS [1:33.491s] > [INFO] Lens Examples ..................................... SUCCESS [0.825s] > [INFO] Lens Distribution ................................. SUCCESS [3.578s] > [INFO] Lens Client Distribution .......................... SUCCESS [5.855s] > [INFO] Lens ML Lib ....................................... SUCCESS [42.395s] > [INFO] Lens Regression ................................... SUCCESS [0.841s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:05.730s > [INFO] Finished at: Mon Feb 09 13:02:22 UTC 2015 > [INFO] Final Memory: 99M/999M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
