> On Feb. 15, 2015, 7:33 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java, > > line 115 > > <https://reviews.apache.org/r/30922/diff/6/?file=863222#file863222line115> > > > > POST on queryapi/queries is used for EXPLAIN, EXECUTE, > > EXECUTE_WITH_TIMEOUT. We would like to have separate instrumentation for > > them. > > > > We might have to include operation param in the name for that.
Can do via an annotation. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30922/#review72518 ----------------------------------------------------------- On Feb. 13, 2015, 9:13 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30922/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 9:13 p.m.) > > > Review request for lens. > > > Bugs: LENS-286 > https://issues.apache.org/jira/browse/LENS-286 > > > Repository: lens > > > Description > ------- > > meters added > > > Diffs > ----- > > lens-server-api/pom.xml f490deeb3a4953282af9a0059224a52abddbafde > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 7d3b9473e44ccd91a60c4b4f14b17bb6cd2267a4 > > lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java > b75bcf4b3af029d3e5b25465fa61d7bad771a89c > lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java > 4f434ce0230196e0dbf96d47f527a192769824a6 > lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java > 2094dfa26c77e2667a0a6d4f4d85db5ce5a2e357 > pom.xml ba861897214a66b3ade54306f54b174ed06e2e59 > > Diff: https://reviews.apache.org/r/30922/diff/ > > > Testing > ------- > > ``` > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$cat > csv_reporter.csv/org.apache.lens.server.session.SessionResource.openSession.POST.meter.csv > t,count,mean_rate,m1_rate,m5_rate,m15_rate,rate_unit > 1423750974,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423750984,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423750994,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751004,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751014,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751024,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751034,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751044,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751054,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751064,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751074,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751084,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751094,1,0.004044,0.015991,0.003306,0.001108,events/second > 1423751104,1,0.003887,0.013536,0.003197,0.001096,events/second > 1423751114,1,0.003743,0.011458,0.003093,0.001084,events/second > 1423751124,1,0.003607,0.009699,0.002991,0.001072,events/second > 1423751134,1,0.003481,0.008210,0.002893,0.001060,events/second > 1423751144,1,0.003365,0.006950,0.002798,0.001048,events/second > 1423751154,1,0.003250,0.005883,0.002706,0.001037,events/second > 1423751164,1,0.003137,0.004980,0.002618,0.001025,events/second > 1423751174,1,0.003056,0.004215,0.002532,0.001014,events/second > 1423751184,1,0.002965,0.003568,0.002449,0.001003,events/second > 1423751194,1,0.002880,0.003020,0.002369,0.000992,events/second > 1423751204,1,0.002800,0.002557,0.002291,0.000981,events/second > 1423751214,1,0.002723,0.002164,0.002216,0.000970,events/second > 1423751224,1,0.002651,0.001832,0.002143,0.000959,events/second > 1423751234,1,0.002582,0.001551,0.002073,0.000948,events/second > 1423751244,2,0.005035,0.016025,0.005256,0.002040,events/second > 1423751254,2,0.004912,0.013565,0.005084,0.002017,events/second > 1423751264,2,0.004794,0.011483,0.004917,0.001995,events/second > 1423751274,2,0.004682,0.009720,0.004756,0.001973,events/second > 1423751284,2,0.004575,0.008228,0.004600,0.001951,events/second > 1423751294,2,0.004472,0.006965,0.004449,0.001930,events/second > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$ > > ``` > > > ``` > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$cat > csv_reporter.csv/org.apache.lens.server.session.SessionResource.openSession.POST.timer.csv > t,count,max,mean,min,stddev,p50,p75,p95,p98,p99,p999,mean_rate,m1_rate,m5_rate,m15_rate,rate_unit,duration_unit > 1423750974,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423750984,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423750994,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751004,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751014,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751024,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751034,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751044,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751054,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751064,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751074,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751084,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751094,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.004043,0.015991,0.003306,0.001108,calls/second,milliseconds > 1423751104,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003886,0.013536,0.003197,0.001096,calls/second,milliseconds > 1423751114,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003742,0.011458,0.003093,0.001084,calls/second,milliseconds > 1423751124,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003607,0.009699,0.002991,0.001072,calls/second,milliseconds > 1423751134,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003481,0.008210,0.002893,0.001060,calls/second,milliseconds > 1423751144,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003364,0.006950,0.002798,0.001048,calls/second,milliseconds > 1423751154,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003241,0.005883,0.002706,0.001037,calls/second,milliseconds > 1423751164,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003135,0.004980,0.002618,0.001025,calls/second,milliseconds > 1423751174,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003056,0.004215,0.002532,0.001014,calls/second,milliseconds > 1423751184,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002965,0.003568,0.002449,0.001003,calls/second,milliseconds > 1423751194,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002880,0.003020,0.002369,0.000992,calls/second,milliseconds > 1423751204,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002799,0.002557,0.002291,0.000981,calls/second,milliseconds > 1423751214,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002722,0.002164,0.002216,0.000970,calls/second,milliseconds > 1423751224,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002651,0.001832,0.002143,0.000959,calls/second,milliseconds > 1423751234,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002582,0.001551,0.002073,0.000948,calls/second,milliseconds > 1423751244,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.005035,0.016025,0.005256,0.002040,calls/second,milliseconds > 1423751254,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004911,0.013565,0.005084,0.002017,calls/second,milliseconds > 1423751264,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004793,0.011483,0.004917,0.001995,calls/second,milliseconds > 1423751274,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004682,0.009720,0.004756,0.001973,calls/second,milliseconds > 1423751284,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004574,0.008228,0.004600,0.001951,calls/second,milliseconds > 1423751294,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004472,0.006965,0.004449,0.001930,calls/second,milliseconds > 1423751304,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004374,0.005895,0.004303,0.001908,calls/second,milliseconds > 1423751314,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004280,0.004990,0.004162,0.001887,calls/second,milliseconds > 1423751324,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004142,0.003886,0.003959,0.001856,calls/second,milliseconds > 1423751334,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004093,0.003576,0.003894,0.001846,calls/second,milliseconds > 1423751344,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004022,0.003027,0.003766,0.001825,calls/second,milliseconds > 1423751354,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.003943,0.002562,0.003643,0.001805,calls/second,milliseconds > 1423751364,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.003866,0.002169,0.003523,0.001785,calls/second,milliseconds > > ``` > > > ``` > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$tail > -f > csv_reporter.csv/org.apache.lens.server.metastore.MetastoreResource.setDatabase.PUT.exceptions.csv > 1423751374,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751384,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751394,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751404,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751414,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751424,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751434,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751444,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751454,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751464,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751474,1,0.001592,0.000000,0.000000,0.000000,events/second > 1423751484,3,0.004709,0.046695,0.009862,0.003318,events/second > 1423751494,3,0.004636,0.039526,0.009539,0.003281,events/second > > ``` > > > Thanks, > > Rajat Khandelwal > >
