----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30870/#review72686 -----------------------------------------------------------
Changes look fine. >> So if we separate the arguments, we'll have to provide them as keyword >> arguments, providing list arguments will not work. Can we document the usage at http://lens.incubator.apache.org/user/cli.html ? Not sure if users will be happy with it or not. If help and documentation can help him, i'm fine with it. - Amareshwari Sriramadasu On Feb. 11, 2015, 10:37 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30870/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 10:37 a.m.) > > > Review request for lens. > > > Bugs: LENS-256 > https://issues.apache.org/jira/browse/LENS-256 > > > Repository: lens > > > Description > ------- > > separating arguments in cli. > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > PRE-CREATION > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 9d835da2c30e096ca77558e075930f0d912e8c17 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > f030d0d0ecbe18344291c94cb2d7e96b9ccbc75a > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > 7539ea9761df15e2ca1847be20d8ac738e13df71 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > f54d8be586546d10e55705e25416e7561269be39 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 0330272d04703f19442e1a497e6d9b9543657559 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java > 3dc29a7dd2e275318d0417eea351027e6f7e2703 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > d2dc6e5e8909a9df9ef49e1d073e460e27333058 > lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml > 24a35fd5fd66d10357f31de7da6478813638bba9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 41f2c9336c3ec25ecfbe8ba289eab462d69844d5 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > cabe3a56e9cb59b0d429ec7fc14780b7ad94f749 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > aa289d3caa4906c8881041ef478713e6dbe18088 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 0d345940d34e02129117c0e6de7c7a7d5cdb4c51 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 4764ac3122e0746ebfa0c25c04e6d71b328caae3 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 9772849a60906aee4ca3512a4d724ca7403976b8 > > Diff: https://reviews.apache.org/r/30870/diff/ > > > Testing > ------- > > Some shortcomings mentioned in jira. > > > Thanks, > > Rajat Khandelwal > >
