On Feb. 17, 2015, 10:41 a.m., Raju Bairishetti wrote: > > One design related suggestion: Instead of keeping two instances of > > `HttpServer`, keep a list. If disabled, don't add ui server to the list. On > > start/shutdown, iterate over the whole list. Would be cleaner.
Will add a list for the servers. This proivdes a way to git rid of null cehcks and isUiServerStartEnabled method - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31067/#review72689 ----------------------------------------------------------- On Feb. 17, 2015, 2:47 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31067/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 2:47 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-304 > https://issues.apache.org/jira/browse/LENS-304 > > > Repository: lens > > > Description > ------- > > We have Lens UI http server different from Lens server. We should have > configuration option to know whether to bring up UI server or not. > > Changes done: > Providing a new config parameter for starting the ui server optional > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > b4cef60 > lens-server/src/main/java/org/apache/lens/server/LensServer.java 5f42005 > lens-server/src/test/java/org/apache/lens/server/TestLensServer.java > PRE-CREATION > src/site/apt/admin/config.apt c5f3b2f > > Diff: https://reviews.apache.org/r/31067/diff/ > > > Testing > ------- > > Tested on local set up by starting the lens server. > > > Thanks, > > Raju Bairishetti > >
