> On Feb. 18, 2015, 3:22 p.m., Himanshu Gahlaut wrote: > > lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java, > > line 150 > > <https://reviews.apache.org/r/30922/diff/12/?file=867750#file867750line150> > > > > An alternative class design could be as follows: > > > > > > Instead of methods in UtilityMethod class for creation of unique > > method name, Lens model objects can be created to add additional behaviors > > on top of jersey model objects ResourceMethod and ContainerRequest. In > > future if we will need more behaviors which are around same jersey model > > objects resourceMethod and containerRequest, then they would be cohesively > > present in these Lens model objects instead of being present in Utility > > classes. > > > > ```java > > public LensResourceMethod { > > > > private ResourceMethod resourceMethod; > > > > public boolean isAnnotationAvailable(final Class clz) { > > return (getAnnotation(clz) != null) ; > > } > > > > public String getAnnotationFormParamName(final Class clz) { > > return getAnnotation(coz).formParamName(); > > } > > > > public String getUniqueMethodName() { > > // use a string builder to create a concatenated unique name > > from Declaring Class, HandlingMethodName and HttpMethodName > > // with a dot separator instead of depending on name static > > method of MetricRegistry here. LensResourceMethod need not be dependent on > > MetricRegistry > > } > > > > private <T> T getAnnotation(Class<T> clz) { > > > > } > > } > > > > public LensContainerRequest { > > > > private ContainerRequest containerRequest; > > > > public String getFormDataFieldValue(final Class<T> clz,final String > > fieldName) { > > return getFormData(clz).getField(fieldName).getValue(); > > } > > > > private <T> T getFormData(final Class<T> clz) { > > > > } > > } > > ``` > > > > MetricsCollector model object can be created which is composed of Timer > > and ExceptionMeters > > > > ```java > > // No need to add @Getter,@Setter or @Data. Data hiding gets > > compromised with these annotations. Shall be avoided wherever possible. > > // No need to add @NoArgsConstructor. The arguments are not validated > > for validation checks in a no args constructor. > > // Add @EqualsAndHashCode, if it helps in equating objects in unit test > > cases. Most of the time it does. > > class MethodMetricsCollector { > > > > private final Timer timer; > > private final Meter meter; > > private final Meter exceptionMeter; > > > > public MethodMetricsCollector(final Timer timer, final Meter meter, > > final Meter exceptionMeter) { > > // Add null check checkArguments on all arguments > > } > > public void markMeters() { > > meter.mark(); > > exceptionMeter.mark(); > > } > > > > public Timer.Context time() { > > } > > > > public void closeTimerContext(final Timer.context context) { > > } > > } > > ``` > > Add a MetricsCollectorFactory which will be dependent on > > MetricsRegistry to create MetricsCollector and also cache them in a map > > with synchronization of critical section wherever required. This leads to > > separation of concern of creation and caching from an inner class in > > MetricsServiceImpl to MetricsCollectorFactory > > > > ```java > > public class MetricsCollectorFactory { > > > > private MetricsRegistry metricsRegistry; > > private static Map<String,MetricsCollector> metricsCollectorMap; > > > > public MetricsCollector createMetricsCollector(final > > LensResourceMethod lrm, final LensContainerRequest lcr) { > > > > String baseMethodName = lrm.getUniqueMethodName(); > > > > if (lrm.isAnnotationAvailable(MultiPurposeResource.class)){ > > > > String annoFormParamName=lrm.getAnnotationFormParamName(); > > > > // Add lcr.getFormDataFieldValue(FormDataMultiPart.class, > > annoFormParamName) to baseMethodName > > } > > > > return createMetricsCollector(baseMethodName); > > } > > > > public MetricsCollector createMetricsCollector(final String name) { > > // If metricsCollector is not available in Map, then create > > it and add to map (synchronize put call to map) > > } > > > > } > > ``` > > Also if any of the method is reaching a stage in implementation where > > null has to be returned and returning null is a success scenario marking > > the absence of an object, then consider modifying the method signature to > > make it more readable by returning Guava Optional objects instead of > > returning null. If returning null represents a failure scenario, then we > > shall consider modifying the method signature to throw an exception. > > > > These classes can be re-used in any higher level object and also unit > > tested separately.
Sounds fine. If it does not require a major revamp of the patch, let us do in this jira. Otherwise shall we create a follow up ticket? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30922/#review72964 ----------------------------------------------------------- On Feb. 18, 2015, 2:43 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30922/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 2:43 p.m.) > > > Review request for lens. > > > Bugs: LENS-286 > https://issues.apache.org/jira/browse/LENS-286 > > > Repository: lens > > > Description > ------- > > After addition, all meters: > > ``` > threads.waiting.count.csv > threads.timed_waiting.count.csv > threads.terminated.count.csv > threads.runnable.count.csv > threads.new.count.csv > threads.deadlocks.csv > threads.daemon.count.csv > threads.count.csv > threads.blocked.count.csv > org.apache.lens.server.ui.SessionUIResource.openSession.POST.timer.csv > org.apache.lens.server.ui.SessionUIResource.openSession.POST.meter.csv > org.apache.lens.server.ui.SessionUIResource.openSession.POST.exceptions.csv > org.apache.lens.server.ui.SessionUIResource.getMessage.GET.timer.csv > org.apache.lens.server.ui.SessionUIResource.getMessage.GET.meter.csv > org.apache.lens.server.ui.SessionUIResource.getMessage.GET.exceptions.csv > org.apache.lens.server.ui.SessionUIResource.closeSession.DELETE.timer.csv > org.apache.lens.server.ui.SessionUIResource.closeSession.DELETE.meter.csv > org.apache.lens.server.ui.SessionUIResource.closeSession.DELETE.exceptions.csv > org.apache.lens.server.ui.MetastoreUIResource.getMessage.GET.timer.csv > org.apache.lens.server.ui.MetastoreUIResource.getMessage.GET.meter.csv > org.apache.lens.server.ui.MetastoreUIResource.getMessage.GET.exceptions.csv > org.apache.lens.server.ui.MetastoreUIResource.getFilterResults.GET.timer.csv > org.apache.lens.server.ui.MetastoreUIResource.getFilterResults.GET.meter.csv > org.apache.lens.server.ui.MetastoreUIResource.getFilterResults.GET.exceptions.csv > org.apache.lens.server.ui.MetastoreUIResource.getDescription.GET.timer.csv > org.apache.lens.server.ui.MetastoreUIResource.getDescription.GET.meter.csv > org.apache.lens.server.ui.MetastoreUIResource.getDescription.GET.exceptions.csv > org.apache.lens.server.ui.MetastoreUIResource.getAllTables.GET.timer.csv > org.apache.lens.server.ui.MetastoreUIResource.getAllTables.GET.meter.csv > org.apache.lens.server.ui.MetastoreUIResource.getAllTables.GET.exceptions.csv > org.apache.lens.server.session.SessionResource.setParam.PUT.timer.csv > org.apache.lens.server.session.SessionResource.setParam.PUT.meter.csv > org.apache.lens.server.session.SessionResource.setParam.PUT.exceptions.csv > org.apache.lens.server.session.SessionResource.openSession.POST.timer.csv > org.apache.lens.server.session.SessionResource.openSession.POST.meter.csv > org.apache.lens.server.session.SessionResource.openSession.POST.exceptions.csv > org.apache.lens.server.session.SessionResource.listResources.GET.timer.csv > org.apache.lens.server.session.SessionResource.listResources.GET.meter.csv > org.apache.lens.server.session.SessionResource.listResources.GET.exceptions.csv > org.apache.lens.server.session.SessionResource.getParams.GET.timer.csv > org.apache.lens.server.session.SessionResource.getParams.GET.meter.csv > org.apache.lens.server.session.SessionResource.getParams.GET.exceptions.csv > org.apache.lens.server.session.SessionResource.getMessage.GET.timer.csv > org.apache.lens.server.session.SessionResource.getMessage.GET.meter.csv > org.apache.lens.server.session.SessionResource.getMessage.GET.exceptions.csv > org.apache.lens.server.session.SessionResource.deleteResource.PUT.timer.csv > org.apache.lens.server.session.SessionResource.deleteResource.PUT.meter.csv > org.apache.lens.server.session.SessionResource.deleteResource.PUT.exceptions.csv > org.apache.lens.server.session.SessionResource.closeSession.DELETE.timer.csv > org.apache.lens.server.session.SessionResource.closeSession.DELETE.meter.csv > org.apache.lens.server.session.SessionResource.closeSession.DELETE.exceptions.csv > org.apache.lens.server.session.SessionResource.addResource.PUT.timer.csv > org.apache.lens.server.session.SessionResource.addResource.PUT.meter.csv > org.apache.lens.server.session.SessionResource.addResource.PUT.exceptions.csv > org.apache.lens.server.scheduler.ScheduleResource.getMessage.GET.timer.csv > org.apache.lens.server.scheduler.ScheduleResource.getMessage.GET.meter.csv > org.apache.lens.server.scheduler.ScheduleResource.getMessage.GET.exceptions.csv > org.apache.lens.server.quota.QuotaResource.getMessage.GET.timer.csv > org.apache.lens.server.quota.QuotaResource.getMessage.GET.meter.csv > org.apache.lens.server.quota.QuotaResource.getMessage.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.updatePreparedConf.PUT.timer.csv > org.apache.lens.server.query.QueryServiceResource.updatePreparedConf.PUT.meter.csv > org.apache.lens.server.query.QueryServiceResource.updatePreparedConf.PUT.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.updateConf.PUT.timer.csv > org.apache.lens.server.query.QueryServiceResource.updateConf.PUT.meter.csv > org.apache.lens.server.query.QueryServiceResource.updateConf.PUT.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.PREPARE.timer.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.PREPARE.meter.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.PREPARE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXPLAIN_AND_PREPARE.timer.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXPLAIN_AND_PREPARE.meter.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXPLAIN_AND_PREPARE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXPLAIN.timer.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXPLAIN.meter.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXPLAIN.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXECUTE_WITH_TIMEOUT.timer.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXECUTE_WITH_TIMEOUT.meter.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXECUTE_WITH_TIMEOUT.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXECUTE.timer.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXECUTE.meter.csv > org.apache.lens.server.query.QueryServiceResource.query.POST.EXECUTE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.PREPARE.timer.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.PREPARE.meter.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.PREPARE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXPLAIN_AND_PREPARE.timer.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXPLAIN_AND_PREPARE.meter.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXPLAIN_AND_PREPARE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXPLAIN.timer.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXPLAIN.meter.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXPLAIN.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXECUTE_WITH_TIMEOUT.timer.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXECUTE_WITH_TIMEOUT.meter.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXECUTE_WITH_TIMEOUT.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXECUTE.timer.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXECUTE.meter.csv > org.apache.lens.server.query.QueryServiceResource.prepareQuery.POST.EXECUTE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getStatus.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getStatus.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getResultSetMetadata.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getResultSetMetadata.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getResultSetMetadata.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getResultSet.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getResultSet.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getResultSet.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getPreparedQuery.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getPreparedQuery.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getPreparedQuery.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getMessage.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getMessage.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getMessage.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getHttpResultSet.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getHttpResultSet.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getHttpResultSet.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getAllQueries.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getAllQueries.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getAllQueries.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.getAllPreparedQueries.GET.timer.csv > org.apache.lens.server.query.QueryServiceResource.getAllPreparedQueries.GET.meter.csv > org.apache.lens.server.query.QueryServiceResource.getAllPreparedQueries.GET.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.PREPARE.timer.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.PREPARE.meter.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.PREPARE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXPLAIN_AND_PREPARE.timer.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXPLAIN_AND_PREPARE.meter.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXPLAIN_AND_PREPARE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXPLAIN.timer.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXPLAIN.meter.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXPLAIN.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXECUTE_WITH_TIMEOUT.timer.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXECUTE_WITH_TIMEOUT.meter.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXECUTE_WITH_TIMEOUT.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXECUTE.timer.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXECUTE.meter.csv > org.apache.lens.server.query.QueryServiceResource.executePrepared.POST.EXECUTE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.destroyPreparedQueries.DELETE.timer.csv > org.apache.lens.server.query.QueryServiceResource.destroyPreparedQueries.DELETE.meter.csv > org.apache.lens.server.query.QueryServiceResource.destroyPreparedQueries.DELETE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.destroyPrepared.DELETE.timer.csv > org.apache.lens.server.query.QueryServiceResource.destroyPrepared.DELETE.meter.csv > org.apache.lens.server.query.QueryServiceResource.destroyPrepared.DELETE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.closeResultSet.DELETE.timer.csv > org.apache.lens.server.query.QueryServiceResource.closeResultSet.DELETE.meter.csv > org.apache.lens.server.query.QueryServiceResource.closeResultSet.DELETE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.cancelQuery.DELETE.timer.csv > org.apache.lens.server.query.QueryServiceResource.cancelQuery.DELETE.meter.csv > org.apache.lens.server.query.QueryServiceResource.cancelQuery.DELETE.exceptions.csv > org.apache.lens.server.query.QueryServiceResource.cancelAllQueries.DELETE.timer.csv > org.apache.lens.server.query.QueryServiceResource.cancelAllQueries.DELETE.meter.csv > org.apache.lens.server.query.QueryServiceResource.cancelAllQueries.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.updateStorage.PUT.timer.csv > org.apache.lens.server.metastore.MetastoreResource.updateStorage.PUT.meter.csv > org.apache.lens.server.metastore.MetastoreResource.updateStorage.PUT.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.updateFactTable.PUT.timer.csv > org.apache.lens.server.metastore.MetastoreResource.updateFactTable.PUT.meter.csv > org.apache.lens.server.metastore.MetastoreResource.updateFactTable.PUT.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.updateDimension.PUT.timer.csv > org.apache.lens.server.metastore.MetastoreResource.updateDimension.PUT.meter.csv > org.apache.lens.server.metastore.MetastoreResource.updateDimension.PUT.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.updateCubeDimension.PUT.timer.csv > org.apache.lens.server.metastore.MetastoreResource.updateCubeDimension.PUT.meter.csv > org.apache.lens.server.metastore.MetastoreResource.updateCubeDimension.PUT.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.updateCube.PUT.timer.csv > org.apache.lens.server.metastore.MetastoreResource.updateCube.PUT.meter.csv > org.apache.lens.server.metastore.MetastoreResource.updateCube.PUT.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.setDatabase.PUT.timer.csv > org.apache.lens.server.metastore.MetastoreResource.setDatabase.PUT.meter.csv > org.apache.lens.server.metastore.MetastoreResource.setDatabase.PUT.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getStoragesOfFact.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getStoragesOfFact.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getStoragesOfFact.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getStorageOfFact.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getStorageOfFact.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getStorageOfFact.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getStorageOfDim.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getStorageOfDim.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getStorageOfDim.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getStorage.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getStorage.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getStorage.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getNativeTable.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getNativeTable.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getNativeTable.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getMessage.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getMessage.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getMessage.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getLatestDateOfCube.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getLatestDateOfCube.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getLatestDateOfCube.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getFlattenedColumns.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getFlattenedColumns.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getFlattenedColumns.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getFactTable.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getFactTable.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getFactTable.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getDimensionTable.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getDimensionTable.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getDimensionTable.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getDimensionStorages.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getDimensionStorages.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getDimensionStorages.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getDimension.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getDimension.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getDimension.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getDatabase.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getDatabase.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getDatabase.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getCube.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getCube.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getCube.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllStorages.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllStorages.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllStorages.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllPartitionsOfFactStorageByFilter.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllPartitionsOfFactStorageByFilter.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllPartitionsOfFactStorageByFilter.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllPartitionsOfDimStorage.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllPartitionsOfDimStorage.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllPartitionsOfDimStorage.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllNativeTables.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllNativeTables.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllNativeTables.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllFactsOfCube.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllFactsOfCube.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllFactsOfCube.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllFacts.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllFacts.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllFacts.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDims.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDims.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDims.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDatabases.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDatabases.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllDatabases.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.getAllCubes.GET.timer.csv > org.apache.lens.server.metastore.MetastoreResource.getAllCubes.GET.meter.csv > org.apache.lens.server.metastore.MetastoreResource.getAllCubes.GET.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorageOfDim.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorageOfDim.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorageOfDim.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorageFromFact.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorageFromFact.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorageFromFact.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorage.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorage.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropStorage.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfFactStorageByFilter.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfFactStorageByFilter.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfFactStorageByFilter.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfDimStorageByValue.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfDimStorageByValue.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfDimStorageByValue.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfDimStorageByFilter.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfDimStorageByFilter.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionsOfDimStorageByFilter.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionOfFactStorageByValues.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionOfFactStorageByValues.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropPartitionOfFactStorageByValues.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropFactTable.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropFactTable.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropFactTable.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropDimensionTable.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropDimensionTable.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropDimensionTable.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropDimension.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropDimension.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropDimension.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropDatabase.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropDatabase.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropDatabase.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropCube.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropCube.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropCube.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropAllStoragesOfFact.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropAllStoragesOfFact.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropAllStoragesOfFact.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.dropAllStoragesOfDim.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.dropAllStoragesOfDim.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.dropAllStoragesOfDim.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllStorages.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllStorages.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllStorages.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllFacts.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllFacts.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllFacts.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllDimensions.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllDimensions.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllDimensions.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllCubes.DELETE.timer.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllCubes.DELETE.meter.csv > org.apache.lens.server.metastore.MetastoreResource.deleteAllCubes.DELETE.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createNewStorage.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createNewStorage.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createNewStorage.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createNewCube.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createNewCube.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createNewCube.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createFactTable.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createFactTable.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createFactTable.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createDimensionTable.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createDimensionTable.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createDimensionTable.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createDimensionStorage.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createDimensionStorage.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createDimensionStorage.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createDimension.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createDimension.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createDimension.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.createDatabase.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.createDatabase.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.createDatabase.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.addStorageToFact.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.addStorageToFact.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.addStorageToFact.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.addPartitionToFactStorage.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.addPartitionToFactStorage.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.addPartitionToFactStorage.POST.exceptions.csv > org.apache.lens.server.metastore.MetastoreResource.addPartitionToDimStorage.POST.timer.csv > org.apache.lens.server.metastore.MetastoreResource.addPartitionToDimStorage.POST.meter.csv > org.apache.lens.server.metastore.MetastoreResource.addPartitionToDimStorage.POST.exceptions.csv > org.apache.lens.server.api.query.QueryExecutionService.total-success-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.total-finished-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.total-failed-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.total-cancelled-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.total-accepted-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.running-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.queued-queries.csv > org.apache.lens.server.api.query.QueryExecutionService.finished-queries.csv > org.apache.lens.server.LensRequestListener.http-requests-started.csv > org.apache.lens.server.LensRequestListener.http-requests-finished.csv > org.apache.lens.server.IndexResource.getThreadDump.GET.timer.csv > org.apache.lens.server.IndexResource.getThreadDump.GET.meter.csv > org.apache.lens.server.IndexResource.getThreadDump.GET.exceptions.csv > org.apache.lens.server.IndexResource.getStatus.GET.timer.csv > org.apache.lens.server.IndexResource.getStatus.GET.meter.csv > org.apache.lens.server.IndexResource.getStatus.GET.exceptions.csv > org.apache.lens.server.IndexResource.getMessage.GET.timer.csv > org.apache.lens.server.IndexResource.getMessage.GET.meter.csv > org.apache.lens.server.IndexResource.getMessage.GET.exceptions.csv > org.apache.lens.server.IndexResource.getIndexMessage.GET.timer.csv > org.apache.lens.server.IndexResource.getIndexMessage.GET.meter.csv > org.apache.lens.server.IndexResource.getIndexMessage.GET.exceptions.csv > memory.total.used.csv > memory.total.max.csv > memory.total.init.csv > memory.total.committed.csv > memory.pools.Tenured-Gen.usage.csv > memory.pools.Survivor-Space.usage.csv > memory.pools.Perm-Gen.usage.csv > memory.pools.Eden-Space.usage.csv > memory.pools.Code-Cache.usage.csv > memory.non-heap.used.csv > memory.non-heap.usage.csv > memory.non-heap.max.csv > memory.non-heap.init.csv > memory.non-heap.committed.csv > memory.heap.used.csv > memory.heap.usage.csv > memory.heap.max.csv > memory.heap.init.csv > memory.heap.committed.csv > jvm.vendor.csv > jvm.uptime.csv > jvm.name.csv > gc.MarkSweepCompact.time.csv > gc.MarkSweepCompact.count.csv > gc.Copy.time.csv > gc.Copy.count.csv > ``` > > > Diffs > ----- > > lens-server-api/pom.xml f490deeb3a4953282af9a0059224a52abddbafde > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > fdfce93f0d5ff8d151ccac4238f75c07b95d115c > > lens-server-api/src/main/java/org/apache/lens/server/api/annotations/MultiPurposeResource.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 7d3b9473e44ccd91a60c4b4f14b17bb6cd2267a4 > lens-server/pom.xml 0986ab92c2562f8ee452f72bca504619da1dfef2 > > lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java > b75bcf4b3af029d3e5b25465fa61d7bad771a89c > lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java > 4f434ce0230196e0dbf96d47f527a192769824a6 > lens-server/src/main/java/org/apache/lens/server/LensServer.java > 4ce3e0478785cbbed26bac2e17f93cc19bc057c6 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > 2c870f12e48cfb7406756c3741f69b6625ff114b > lens-server/src/main/java/org/apache/lens/server/MetricsServiceImpl.java > 2094dfa26c77e2667a0a6d4f4d85db5ce5a2e357 > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 8d6037fdf7f76676f4a13606f2164f1caaccb03e > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 3f2e8176e269604fc09dc72f0577af8d960f803d > lens-server/src/main/resources/lensserver-default.xml > 331448f432141342f4b370ca2f64f1d4a0669372 > lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java > 1e31fada85ecd0fb8e5f06884ca2595b3c92bb04 > pom.xml 38d1693e749a2b1c67b6097d2159c426c1d1e476 > src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79 > > Diff: https://reviews.apache.org/r/30922/diff/ > > > Testing > ------- > > ``` > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$cat > csv_reporter.csv/org.apache.lens.server.session.SessionResource.openSession.POST.meter.csv > t,count,mean_rate,m1_rate,m5_rate,m15_rate,rate_unit > 1423750974,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423750984,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423750994,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751004,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751014,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751024,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751034,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751044,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751054,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751064,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751074,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751084,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751094,1,0.004044,0.015991,0.003306,0.001108,events/second > 1423751104,1,0.003887,0.013536,0.003197,0.001096,events/second > 1423751114,1,0.003743,0.011458,0.003093,0.001084,events/second > 1423751124,1,0.003607,0.009699,0.002991,0.001072,events/second > 1423751134,1,0.003481,0.008210,0.002893,0.001060,events/second > 1423751144,1,0.003365,0.006950,0.002798,0.001048,events/second > 1423751154,1,0.003250,0.005883,0.002706,0.001037,events/second > 1423751164,1,0.003137,0.004980,0.002618,0.001025,events/second > 1423751174,1,0.003056,0.004215,0.002532,0.001014,events/second > 1423751184,1,0.002965,0.003568,0.002449,0.001003,events/second > 1423751194,1,0.002880,0.003020,0.002369,0.000992,events/second > 1423751204,1,0.002800,0.002557,0.002291,0.000981,events/second > 1423751214,1,0.002723,0.002164,0.002216,0.000970,events/second > 1423751224,1,0.002651,0.001832,0.002143,0.000959,events/second > 1423751234,1,0.002582,0.001551,0.002073,0.000948,events/second > 1423751244,2,0.005035,0.016025,0.005256,0.002040,events/second > 1423751254,2,0.004912,0.013565,0.005084,0.002017,events/second > 1423751264,2,0.004794,0.011483,0.004917,0.001995,events/second > 1423751274,2,0.004682,0.009720,0.004756,0.001973,events/second > 1423751284,2,0.004575,0.008228,0.004600,0.001951,events/second > 1423751294,2,0.004472,0.006965,0.004449,0.001930,events/second > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$ > > ``` > > > ``` > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$cat > csv_reporter.csv/org.apache.lens.server.session.SessionResource.openSession.POST.timer.csv > t,count,max,mean,min,stddev,p50,p75,p95,p98,p99,p999,mean_rate,m1_rate,m5_rate,m15_rate,rate_unit,duration_unit > 1423750974,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423750984,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423750994,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751004,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751014,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751024,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751034,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751044,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751054,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751064,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751074,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751084,0,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,calls/second,milliseconds > 1423751094,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.004043,0.015991,0.003306,0.001108,calls/second,milliseconds > 1423751104,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003886,0.013536,0.003197,0.001096,calls/second,milliseconds > 1423751114,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003742,0.011458,0.003093,0.001084,calls/second,milliseconds > 1423751124,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003607,0.009699,0.002991,0.001072,calls/second,milliseconds > 1423751134,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003481,0.008210,0.002893,0.001060,calls/second,milliseconds > 1423751144,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003364,0.006950,0.002798,0.001048,calls/second,milliseconds > 1423751154,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003241,0.005883,0.002706,0.001037,calls/second,milliseconds > 1423751164,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003135,0.004980,0.002618,0.001025,calls/second,milliseconds > 1423751174,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.003056,0.004215,0.002532,0.001014,calls/second,milliseconds > 1423751184,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002965,0.003568,0.002449,0.001003,calls/second,milliseconds > 1423751194,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002880,0.003020,0.002369,0.000992,calls/second,milliseconds > 1423751204,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002799,0.002557,0.002291,0.000981,calls/second,milliseconds > 1423751214,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002722,0.002164,0.002216,0.000970,calls/second,milliseconds > 1423751224,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002651,0.001832,0.002143,0.000959,calls/second,milliseconds > 1423751234,1,152.748000,152.748000,152.748000,0.000000,152.748000,152.748000,152.748000,152.748000,152.748000,152.748000,0.002582,0.001551,0.002073,0.000948,calls/second,milliseconds > 1423751244,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.005035,0.016025,0.005256,0.002040,calls/second,milliseconds > 1423751254,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004911,0.013565,0.005084,0.002017,calls/second,milliseconds > 1423751264,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004793,0.011483,0.004917,0.001995,calls/second,milliseconds > 1423751274,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004682,0.009720,0.004756,0.001973,calls/second,milliseconds > 1423751284,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004574,0.008228,0.004600,0.001951,calls/second,milliseconds > 1423751294,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004472,0.006965,0.004449,0.001930,calls/second,milliseconds > 1423751304,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004374,0.005895,0.004303,0.001908,calls/second,milliseconds > 1423751314,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004280,0.004990,0.004162,0.001887,calls/second,milliseconds > 1423751324,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004142,0.003886,0.003959,0.001856,calls/second,milliseconds > 1423751334,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004093,0.003576,0.003894,0.001846,calls/second,milliseconds > 1423751344,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.004022,0.003027,0.003766,0.001825,calls/second,milliseconds > 1423751354,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.003943,0.002562,0.003643,0.001805,calls/second,milliseconds > 1423751364,2,629.011000,390.879500,152.748000,336.768797,390.879500,629.011000,629.011000,629.011000,629.011000,629.011000,0.003866,0.002169,0.003523,0.001785,calls/second,milliseconds > > ``` > > > ``` > [~/Git/grill/lens-dist/target/lens-dist-2.1.0-incubating-SNAPSHOT-server]$tail > -f > csv_reporter.csv/org.apache.lens.server.metastore.MetastoreResource.setDatabase.PUT.exceptions.csv > 1423751374,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751384,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751394,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751404,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751414,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751424,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751434,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751444,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751454,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751464,0,0.000000,0.000000,0.000000,0.000000,events/second > 1423751474,1,0.001592,0.000000,0.000000,0.000000,events/second > 1423751484,3,0.004709,0.046695,0.009862,0.003318,events/second > 1423751494,3,0.004636,0.039526,0.009539,0.003281,events/second > > ``` > > > Thanks, > > Rajat Khandelwal > >
