----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31531/#review74464 -----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java <https://reviews.apache.org/r/31531/#comment121052> Can you put different order than x, y and z? This is alphabatical order also, lets put reverse order for order file to be tested - Amareshwari Sriramadasu On Feb. 27, 2015, 9:13 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31531/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 9:13 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-361 > https://issues.apache.org/jira/browse/LENS-361 > > > Repository: lens > > > Description > ------- > > 1. Using add jars when sending DB jars to hive driver, to reduce number of > queries run to add resources. > 2. Jar order specified in jar_order file in the db jar directory. One jar per > line. Same order is passed on to Hive driver. > 3. Setting session id in prepared and explain query contexts. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1217e38d38d02ebc49e2a98d38638e9f4bd10633 > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > df2d746169629ecd71c91eef1b639afe8e713a1f > lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java > d5f38727c594ca34e21f2e19d280854f64c21ed5 > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java > c6cd18010ae5bff195ca6ce52f0173a52b94a349 > > Diff: https://reviews.apache.org/r/31531/diff/ > > > Testing > ------- > > 1. Verified jars picked up by DatabaseResourceService in the order specified > in jar_order file > 2. Verified jars added to hive session in correct order > > Awaiting Test output - > > > Thanks, > > Jaideep dhok > >
