----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31588/#review74694 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On March 1, 2015, 12:02 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31588/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 12:02 p.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-369 > https://issues.apache.org/jira/browse/LENS-369 > > > Repository: lens > > > Description > ------- > > Changes include : > > - CubeMetastoreClient to make copy of session config passed > - Fixed reading from jar_order file to skip empty lines > - Set correct classloader in cube metastore client > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > bca9870 > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > d455e34 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > c02e76b > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java > af642b8 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 73621a3 > > Diff: https://reviews.apache.org/r/31588/diff/ > > > Testing > ------- > > Added unit tests which are failing with above changes, which pass now. > > * Tested scenarios with new session operations starting in metastore service > calls like show cubes/ show facts/ describe native tables - just after server > startup. > * Tested scenatios with new session operations starting in query service > calls with explain and execute - just after server startup > * Tested scenarios with sessions being accessing metastore/query service with > server restart inbetween. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.942s] > [INFO] Lens .............................................. SUCCESS [1.936s] > [INFO] Lens API .......................................... SUCCESS [4.710s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.618s] > [INFO] Lens Cube ......................................... SUCCESS [6:15.708s] > [INFO] Lens DB storage ................................... SUCCESS [10.478s] > [INFO] Lens Query Library ................................ SUCCESS [4.860s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:36.546s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [24.967s] > [INFO] Lens Server ....................................... SUCCESS [4:32.021s] > [INFO] Lens client ....................................... SUCCESS [21.411s] > [INFO] Lens CLI .......................................... SUCCESS [1:28.748s] > [INFO] Lens Examples ..................................... SUCCESS [0.766s] > [INFO] Lens Distribution ................................. SUCCESS [8.942s] > [INFO] Lens ML Lib ....................................... SUCCESS [43.472s] > [INFO] Lens Regression ................................... SUCCESS [0.497s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:03.548s > [INFO] Finished at: Sun Mar 01 06:32:01 UTC 2015 > [INFO] Final Memory: 99M/1351M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
