> On Feb. 24, 2015, 12:50 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 366 > > <https://reviews.apache.org/r/31154/diff/3/?file=867831#file867831line366> > > > > We should remove symlinked latest partitions as well when we move to > > table partitions from symlinks. > > > > Otherwise, those would be holding old values and cause confusion.
We need to add an integration test in which we create partition with older version of lens (which creates `latest` partition) and do another partition operation with a newer version of lens(which should delete the `latest` partition and keep the info in table properties. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31154/#review73529 ----------------------------------------------------------- On March 1, 2015, 7:53 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31154/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 7:53 p.m.) > > > Review request for lens. > > > Bugs: LENS-280 > https://issues.apache.org/jira/browse/LENS-280 > > > Repository: lens > > > Description > ------- > > Posting the changes that show the logic change. Not complete yet, it's just > so that anyone who wants to look at the new logic can see. > > cube tests are all passing, remaining things: > > > 1. PartitionInfo API, name change and some util methods addition > 2. Some newly added methods and code belongs in other classes, will move them > appropriately. > 3. Server tests,(TestMetastoreResource) > 4. javadoc > 5. will see if some more abstraction can be made, redundancies removed. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > b3ed6efd102ed800519ebb9b5d15f81a2a32d5d5 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 7e6fe7e93a07ddb6ae4369b78e7856dc2b0a65b5 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 979de6d7f1d43f0fb5621e3287f3a6eef3dcdaef > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > c21c72a5ceb0271134423b8a9caf928e524cf150 > lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionInfo.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > 240516d6911ecdab6a07ef77b194c013aba42f4e > lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageConstants.java > c4b3c3a4d469f5cc609db67437b00855d907c51d > > lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java > b1a85adfb229fa0f6a708a047a7629b2faa28e30 > lens-cube/src/main/java/org/apache/lens/cube/parse/FactPartition.java > a60041bf3df0fa03091674b602a78a2323f88d55 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 7eaf597bac879430dff086914865d34102003f0f > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java > 550df6c99b7ffe7372d319b8c4b101cdd5a4f830 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 96ba240404d1f21fbcac572ced0a4e3c911a5731 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 3c960622c4bc7d95bcbd9c66f3f64a8c7eff2cd2 > > Diff: https://reviews.apache.org/r/31154/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
