----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31608/#review74719 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java <https://reviews.apache.org/r/31608/#comment121423> Should we catch all exceptions instead of HiveException alone? lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java <https://reviews.apache.org/r/31608/#comment121424> Can you check if failures in add jars is taken care not to leak opened session? - Amareshwari Sriramadasu On March 2, 2015, 5:46 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31608/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 5:46 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-364 > https://issues.apache.org/jira/browse/LENS-364 > > > Repository: lens > > > Description > ------- > > 1. Closing session before throwing 404. > 2. Closing session in case db exist check throws exception > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 435eda9d6d38724e7e7ace063d49064a79a1f999 > > Diff: https://reviews.apache.org/r/31608/diff/ > > > Testing > ------- > > Checked log statement in case of invalid DB. > No new test added as test for open session with invalid DB already exists. > > Awaiting test output. > > > Thanks, > > Jaideep dhok > >
