> On March 3, 2015, 1:31 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/resources/lens-site.xml, line 130 > > <https://reviews.apache.org/r/31670/diff/1/?file=882782#file882782line130> > > > > Is it specific to hsql? Shouldnt be. Please update description.
Yes. specific to hsql. The description inside `lens-server-default` is updated. > On March 3, 2015, 1:31 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/resources/lens-site.xml, line 129 > > <https://reviews.apache.org/r/31670/diff/1/?file=882782#file882782line129> > > > > What happens if user does not have access to query > > INFORMATION_SCHEMA.SYSTEM_USERS This is only for our test cases. Which use hsqldb. hsql doc(http://hsqldb.org/doc/guide/accesscontrol-chapt.html) mentions: ``` The Standard effectively defines a special ROLE, named PUBLIC. All authorization have the PUBLIC role, which cannot be removed from them. Therefore any access right assigned to the PUBLIC role applies to all authorizations in the database. For many simple databases, it is adequate to create a single, non-admin user, then assign access rights to the pre-existing PUBLIC role. Access to INFORMATION_SCHEMA views is granted to PUBLIC, therefore these views are accessible to all. However, the contents of each view depends on the ROLE or USER (AUTHORIZATION) that is in force while accessing the view. ``` - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31670/#review74918 ----------------------------------------------------------- On March 3, 2015, 1:43 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31670/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 1:43 p.m.) > > > Review request for lens. > > > Bugs: LENS-168 > https://issues.apache.org/jira/browse/LENS-168 > > > Repository: lens > > > Description > ------- > > added validationQuery > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > ca87fa3e12f1b117c1249e27056cff41036c1ccf > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 3f2e8176e269604fc09dc72f0577af8d960f803d > lens-server/src/main/resources/lensserver-default.xml > 4b60cd5b92d4f2c1db8f8a9e6cebccc80adbe74a > lens-server/src/test/resources/lens-site.xml > 118ecdcf31679f6c03406ee5eb3fc162c3573367 > src/site/apt/admin/config.apt 6445fe734fe8fc5082aba06c61ec3a5dc35a7b61 > src/site/apt/admin/session-config.apt > d1c36bb91b4829b9fa40836c1ca2191ee4d3017b > > Diff: https://reviews.apache.org/r/31670/diff/ > > > Testing > ------- > > mvn clean install -DskipTests passes. > > No new tests added, new config param also not used in test cases. Since it's > not breaking anything, can push it. > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.009s] > [INFO] Lens .............................................. SUCCESS [2.057s] > [INFO] Lens API .......................................... SUCCESS [5.487s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.173s] > [INFO] Lens Cube ......................................... SUCCESS [6:13.074s] > [INFO] Lens DB storage ................................... SUCCESS [9.809s] > [INFO] Lens Query Library ................................ SUCCESS [4.578s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:33.976s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [25.457s] > [INFO] Lens Server ....................................... SUCCESS [4:26.229s] > [INFO] Lens client ....................................... SUCCESS [20.279s] > [INFO] Lens CLI .......................................... SUCCESS [1:40.666s] > [INFO] Lens Examples ..................................... SUCCESS [0.780s] > [INFO] Lens Distribution ................................. SUCCESS [9.389s] > [INFO] Lens ML Lib ....................................... SUCCESS [44.977s] > [INFO] Lens Regression ................................... SUCCESS [0.478s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:06.331s > [INFO] Finished at: Tue Mar 03 07:58:45 UTC 2015 > [INFO] Final Memory: 109M/991M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
