> On March 4, 2015, 11:40 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 2211 > > <https://reviews.apache.org/r/31623/diff/3/?file=882771#file882771line2211> > > > > whats the purpose of this boolean? I see it is immediately set to true > > Jaideep dhok wrote: > This is to check if we entered the loop. Since we are maintaining flag > for resources added at session level, we have to reset that flag so that > resources of switched db get added, but only if we removed at least one > resource for the old db.
Just realized this could cause jars of new db not being added. Will remove the check around this variable. - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31623/#review75168 ----------------------------------------------------------- On March 3, 2015, 7:34 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31623/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 7:34 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-349 > https://issues.apache.org/jira/browse/LENS-349 > > > Repository: lens > > > Description > ------- > > Checking if DB changed in query service, if yes removing resources of old db > and then add resources of new db > > > Diffs > ----- > > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > fd294664aaac300c4e3036dab8796dd228fb03e1 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > e7619ed8972d37af6c5450273e8940abf61c5a9b > lens-driver-jdbc/testdata/DatabaseJarSerde.java > 03caff31916072b0e6944d1bd13161dca5cef878 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 15b9849cf51aa91670f0d9780a796211d834007d > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 8c970821015b04e4adaff7d2949520ea5a0c4c82 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > a695b5d4d6363ff4693cffc0ae2b97ce35e97344 > lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java > e44816372e889bdc7ce2ac34a43048e8af85181e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c350d09763d120ad5d6b2cdea68aec5f84279058 > lens-server/testdata/DatabaseJarSerde.java > 03caff31916072b0e6944d1bd13161dca5cef878 > lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543 > lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f > > Diff: https://reviews.apache.org/r/31623/diff/ > > > Testing > ------- > > changed unit test to add test for db switch > > Test output - > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.197s] > [INFO] Lens .............................................. SUCCESS [1.968s] > [INFO] Lens API .......................................... SUCCESS [6.211s] > [INFO] Lens API for server and extensions ................ SUCCESS [5.590s] > [INFO] Lens Cube ......................................... SUCCESS [6:05.709s] > [INFO] Lens DB storage ................................... SUCCESS [10.393s] > [INFO] Lens Query Library ................................ SUCCESS [4.467s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:37.007s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [27.348s] > [INFO] Lens Server ....................................... SUCCESS [4:36.390s] > [INFO] Lens client ....................................... SUCCESS [22.509s] > [INFO] Lens CLI .......................................... SUCCESS [1:55.014s] > [INFO] Lens Examples ..................................... SUCCESS [0.916s] > [INFO] Lens Distribution ................................. SUCCESS [9.843s] > [INFO] Lens ML Lib ....................................... SUCCESS [44.491s] > [INFO] Lens Regression ................................... SUCCESS [0.498s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:31.512s > [INFO] Finished at: Tue Mar 03 07:31:49 UTC 2015 > [INFO] Final Memory: 111M/975M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jaideep dhok > >
