----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31857/#review75855 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java <https://reviews.apache.org/r/31857/#comment123179> isEmpty check is unnecessary. lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java <https://reviews.apache.org/r/31857/#comment123180> is there a null check required here - Jaideep dhok On March 10, 2015, 5:39 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31857/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 5:39 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-393 > https://issues.apache.org/jira/browse/LENS-393 > > > Repository: lens > > > Description > ------- > > Fixed the validaiton and added tests as well > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > 6ef72d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 609b7f3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 78e0b80 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 66f160d > > Diff: https://reviews.apache.org/r/31857/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.268s] > [INFO] Lens .............................................. SUCCESS [2.261s] > [INFO] Lens API .......................................... SUCCESS [6.300s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.321s] > [INFO] Lens Cube ......................................... SUCCESS [6:13.469s] > [INFO] Lens DB storage ................................... SUCCESS [10.638s] > [INFO] Lens Query Library ................................ SUCCESS [5.219s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:36.769s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [26.335s] > [INFO] Lens Server ....................................... SUCCESS [4:27.501s] > [INFO] Lens client ....................................... SUCCESS [21.108s] > [INFO] Lens CLI .......................................... SUCCESS [1:30.081s] > [INFO] Lens Examples ..................................... SUCCESS [0.847s] > [INFO] Lens Distribution ................................. SUCCESS [9.314s] > [INFO] Lens ML Lib ....................................... SUCCESS [45.472s] > [INFO] Lens Regression ................................... SUCCESS [0.486s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:05.345s > [INFO] Finished at: Tue Mar 10 05:23:27 UTC 2015 > [INFO] Final Memory: 99M/1326M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
