> On March 12, 2015, 9:31 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml, line 88 > > <https://reviews.apache.org/r/31931/diff/3/?file=892036#file892036line88> > > > > Will this ever be different for estimate pool. I would say no. Shouldnt > > be configurable > > Jaideep dhok wrote: > Either we should allow all config to be overridden or none at all.
The only thing that concerns me is should we allow different db uri to be given for estimate and execute? When we allow, what does that mean? Can estimate be run on different db than execute? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31931/#review76221 ----------------------------------------------------------- On March 12, 2015, 8:54 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31931/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 8:54 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-329 > https://issues.apache.org/jira/browse/LENS-329 > > > Repository: lens > > > Description > ------- > > Using different connection pool for estimate queries. Added new config for > tuning estimate connection pool. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java > dcd6328a47a9f709aef09265b0c5874c026d40c8 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > d67e1da0c97c8118ab0127135cc9ef95febe059c > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml > 03c5414573eabd3b98ed99c7757ee294df608178 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 6c1d77e47e7f9b73c0c242511730203367f9ed17 > lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 76867623ada723c1bfbde6b91071ccf482827302 > lens-server/src/test/resources/jdbcdriver-site.xml > c5dbd861caec66be4ca63febd8f7489c7b19dc04 > src/site/apt/admin/jdbcdriver-config.apt > dc325f1bf89a670ccaa9a5079503932f019b961d > > Diff: https://reviews.apache.org/r/31931/diff/ > > > Testing > ------- > > Added unit tests to validate that estimate queries uses separate connection > pool. > Added unit test to validate that estimate config overrides default config for > estimate pool. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.101s] > [INFO] Lens .............................................. SUCCESS [1.756s] > [INFO] Lens API .......................................... SUCCESS [4.673s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.538s] > [INFO] Lens Cube ......................................... SUCCESS [2:22.584s] > [INFO] Lens DB storage ................................... SUCCESS [9.473s] > [INFO] Lens Query Library ................................ SUCCESS [4.562s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:33.355s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [26.091s] > [INFO] Lens Server ....................................... SUCCESS [4:55.318s] > [INFO] Lens client ....................................... SUCCESS [25.918s] > [INFO] Lens CLI .......................................... SUCCESS [2:10.512s] > [INFO] Lens Examples ..................................... SUCCESS [1.183s] > [INFO] Lens Distribution ................................. SUCCESS [13.537s] > [INFO] Lens ML Lib ....................................... SUCCESS [54.204s] > [INFO] Lens Regression ................................... SUCCESS [0.690s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:33.449s > [INFO] Finished at: Thu Mar 12 08:45:50 UTC 2015 > [INFO] Final Memory: 109M/1176M > [INFO] > ------------------------------------------------------------------------ > [SLOCCount] Report successfully processed and all data stored > Recording test results > Finished: SUCCESS > > > Thanks, > > Jaideep dhok > >
