> On March 17, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java, > > line 33 > > <https://reviews.apache.org/r/32100/diff/4/?file=896079#file896079line33> > > > > Dont remove the hooks for single partition addition
Would be painful for the implementors to implement two methods. Most of the code will be same anyway in their implementations > On March 17, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 720 > > <https://reviews.apache.org/r/32100/diff/4/?file=896077#file896077line720> > > > > We might always have single partition getting added for dimtable > > storages. Multiple partitions might never be added. We can remove a lot of > > code with respect to that. We can do a follow up, not blocking this patch > > for this. That is taken care in `addPartition` method. This method doesn't need to care for that. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32100/#review76715 ----------------------------------------------------------- On March 16, 2015, 10:52 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32100/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 10:52 p.m.) > > > Review request for lens. > > > Bugs: LENS-282 > https://issues.apache.org/jira/browse/LENS-282 > > > Repository: lens > > > Description > ------- > > add partitions > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 10e8ec082622ca88a8599e9426befab0837a8704 > lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java > efc4d64ed1d63e8b85c53717579acd998ee3ae32 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java > 84293f48636829cc0f2a80cb62f552878319c359 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > d442bc0859b17a3b284a5456f7e464be5c8f4883 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java > 30921df3ebf54684b1060a288d2629647b0a143d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java > c79c9ceebd6bab9150793214e3526c5c2f5d2f7c > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 33224e92e1a23ff67d3a24a4566f0f886cfb86b3 > lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java > de2f8652124f811c87a9031412ac4aa09eb08830 > > Diff: https://reviews.apache.org/r/32100/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s] > [INFO] Lens .............................................. SUCCESS [1.834s] > [INFO] Lens API .......................................... SUCCESS [4.747s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.213s] > [INFO] Lens Cube ......................................... SUCCESS [2:20.758s] > [INFO] Lens DB storage ................................... SUCCESS [10.204s] > [INFO] Lens Query Library ................................ SUCCESS [5.156s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s] > [INFO] Lens Server ....................................... SUCCESS [4:21.275s] > [INFO] Lens client ....................................... SUCCESS [21.300s] > [INFO] Lens CLI .......................................... SUCCESS [1:49.842s] > [INFO] Lens Examples ..................................... SUCCESS [0.946s] > [INFO] Lens Distribution ................................. SUCCESS [9.783s] > [INFO] Lens ML Lib ....................................... SUCCESS [44.071s] > [INFO] Lens Regression ................................... SUCCESS [0.483s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:20.811s > [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015 > [INFO] Final Memory: 109M/1181M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
