----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32194/#review76881 -----------------------------------------------------------
Ship it! Ship It! - Jaideep dhok On March 18, 2015, 8:42 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32194/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 8:42 a.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-417 > https://issues.apache.org/jira/browse/LENS-417 > > > Repository: lens > > > Description > ------- > > Changes include : > > - Prepare context to merge driver conf > - Updated unit tests which fail without the fix > - Fixed prepareInternal getting called to have separate gauges in validate > and prepare flow > - Fixed PrepareHandle leak for failed prepare queries in > QueryExecutionServiceImpl - was hitting this with newly added tests. > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 73d53f6 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 5236602 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 786fd34 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > c49567a > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > e3bfed8 > > Diff: https://reviews.apache.org/r/32194/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.042s] > [INFO] Lens .............................................. SUCCESS [1.927s] > [INFO] Lens API .......................................... SUCCESS [5.450s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.334s] > [INFO] Lens Cube ......................................... SUCCESS [2:09.694s] > [INFO] Lens DB storage ................................... SUCCESS [10.424s] > [INFO] Lens Query Library ................................ SUCCESS [4.324s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:34.267s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.890s] > [INFO] Lens Server ....................................... SUCCESS [4:18.557s] > [INFO] Lens client ....................................... SUCCESS [20.534s] > [INFO] Lens CLI .......................................... SUCCESS [2:52.697s] > [INFO] Lens Examples ..................................... SUCCESS [0.790s] > [INFO] Lens Distribution ................................. SUCCESS [10.048s] > [INFO] Lens ML Lib ....................................... SUCCESS [44.742s] > [INFO] Lens Regression ................................... SUCCESS [0.457s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:01.133s > [INFO] Finished at: Wed Mar 18 07:13:43 UTC 2015 > [INFO] Final Memory: 99M/1257M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
