> On March 18, 2015, 9:55 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 988 > > <https://reviews.apache.org/r/32101/diff/2/?file=897606#file897606line988> > > > > Should we think about the case where a dimension has multiple time > > partitions
The only timedimension allowed for dimension tables is dumping at a snapshot interval and users will be able to query latest dump. Though current code allows multiple timedimensions for a storage table, it does not make sense to have multple timedimensions exposed at DimensionTable. Not changing this functionality - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32101/#review76887 ----------------------------------------------------------- On March 19, 2015, 5:49 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32101/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 5:49 a.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-405 > https://issues.apache.org/jira/browse/LENS-405 > > > Repository: lens > > > Description > ------- > > - Adds simple storage table name cache for which latest partitions exists. > - Cache is initialized on first call to getDimensionTable > - Updated with add and drop partitions > - Updated TestCubeMetastoreClient to assert the cache value > - Fixed CubeTestSetup - city was not getting created with correct dump periods > - Fixed TestMetastoreService to alwasys create Dimension corresponding to > DimTable > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 4ed1163 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > d3647f1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 2029829 > lens-cli/src/test/resources/data.data 6c99c9a > lens-cli/src/test/resources/dim2-part/data.data PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/LensClient.java 4bee3b7 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b0d2e63 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > be1261e > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 33224e9 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > cdf3da6 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 1c63861 > > Diff: https://reviews.apache.org/r/32101/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.882s] > [INFO] Lens .............................................. SUCCESS [2.321s] > [INFO] Lens API .......................................... SUCCESS [7.525s] > [INFO] Lens API for server and extensions ................ SUCCESS [9.422s] > [INFO] Lens Cube ......................................... SUCCESS [2:10.723s] > [INFO] Lens DB storage ................................... SUCCESS [10.385s] > [INFO] Lens Query Library ................................ SUCCESS [4.254s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:37.093s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.394s] > [INFO] Lens Server ....................................... SUCCESS [4:14.897s] > [INFO] Lens client ....................................... SUCCESS [20.816s] > [INFO] Lens CLI .......................................... SUCCESS [1:22.529s] > [INFO] Lens Examples ..................................... SUCCESS [0.839s] > [INFO] Lens Distribution ................................. SUCCESS [9.487s] > [INFO] Lens ML Lib ....................................... SUCCESS [42.318s] > [INFO] Lens Regression ................................... SUCCESS [0.479s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 12:34.412s > [INFO] Finished at: Tue Mar 17 06:47:49 UTC 2015 > [INFO] Final Memory: 110M/1143M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
