> On March 23, 2015, 9:24 a.m., Amareshwari Sriramadasu wrote: > > Changes look fine. As there are no unit tests added for the new code and > > remote server testing with different classpath is not possible in unit > > tests, Can we test it with remote hive server (thru docker or stand alone) > > and update if the changes are working fine?
I'll test LENS-153 patch with this issue. If that passes, we can merge this. - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32390/#review77384 ----------------------------------------------------------- On March 23, 2015, 9:59 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32390/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 9:59 a.m.) > > > Review request for lens and sharad agarwal. > > > Bugs: LENS-154 > https://issues.apache.org/jira/browse/LENS-154 > > > Repository: lens > > > Description > ------- > > Registering UDF before running test query in ML service > > > Diffs > ----- > > lens-ml-lib/src/main/java/org/apache/lens/ml/LensML.java > fe65d2f0386e842d104228f7ff55b5a5cb5320a2 > lens-ml-lib/src/main/java/org/apache/lens/ml/LensMLImpl.java > 2555ca036cec5c41ed13b2ac2f8b5b5a667716e7 > lens-ml-lib/src/main/java/org/apache/lens/ml/ModelLoader.java > 535748bdc9cf47b5cb4aad3d81c21331a0da1e3a > lens-ml-lib/src/main/java/org/apache/lens/ml/TestQueryRunner.java > 41f6961a48d9724bc1711f13e35969df0f5eeeab > lens-ml-lib/src/main/java/org/apache/lens/server/ml/MLServiceImpl.java > 9eb2723d912abd7c47cb11b6a7756cd7328c94f6 > lens-ml-lib/src/test/resources/lens-site.xml > e2f86ae7395e7e5c8dc6862699ae8d7fce2f93a0 > lens-ml-lib/testjars/serde.jar PRE-CREATION > lens-ml-lib/testjars/test.jar PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 74c8b0a977ae9a96d467e2cc3306ebdce918bb1f > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 7ccbfb227fa7eb557632307031227be25134dbd9 > > Diff: https://reviews.apache.org/r/32390/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.163s] > [INFO] Lens .............................................. SUCCESS [1.798s] > [INFO] Lens API .......................................... SUCCESS [5.804s] > [INFO] Lens API for server and extensions ................ SUCCESS [7.066s] > [INFO] Lens Cube ......................................... SUCCESS [2:08.513s] > [INFO] Lens DB storage ................................... SUCCESS [10.076s] > [INFO] Lens Query Library ................................ SUCCESS [4.942s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:32.803s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.273s] > [INFO] Lens Server ....................................... SUCCESS [4:15.698s] > [INFO] Lens client ....................................... SUCCESS [21.332s] > [INFO] Lens CLI .......................................... SUCCESS [3:21.314s] > [INFO] Lens Examples ..................................... SUCCESS [1.475s] > [INFO] Lens Distribution ................................. SUCCESS [13.326s] > [INFO] Lens ML Lib ....................................... SUCCESS [54.289s] > [INFO] Lens Regression ................................... SUCCESS [0.643s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:39.495s > [INFO] Finished at: Mon Mar 23 09:40:48 UTC 2015 > [INFO] Final Memory: 110M/1512M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jaideep dhok > >
