> On March 25, 2015, 12:45 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java, > > line 76 > > <https://reviews.apache.org/r/32393/diff/4/?file=905184#file905184line76> > > > > Can probably make `FactPartition` extend `TimePartition` and make > > another class `DimtablePartitoin` which also extends `TimePartition`. Then > > `Set<?>` can be removed.
Not doing this. I feel DimtablePartition does not have to be timepartition and we are not deciding priority for dimension only queries now. We can have this formulated when we solve more usecases of dimension only queries. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32393/#review77727 ----------------------------------------------------------- On March 25, 2015, 9:10 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32393/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 9:10 a.m.) > > > Review request for lens, Jaideep dhok and Rajat Khandelwal. > > > Bugs: LENS-323 > https://issues.apache.org/jira/browse/LENS-323 > > > Repository: lens > > > Description > ------- > > All changes are complete. Changes include: > > - Generating rewriter plan with cube queries involved > - Populating FactPartitions queried in RewriterPlan > - priority getting set only for cube queries; native tables queries are left > with defaults > - TestHiveDriver.testPriority updated > - Fix other test failures > - Clear transient state in QueryContext after launch. > - Add unit tests for rewriter plan construction > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java > 3ac207e > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 66c3b25 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java > 5eaf7ec > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 9ee1667 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > df5a212 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > d83db18 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > ae7886b > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 0514ecf > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > 5c39982 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > c29d88f > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 354c735 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 8ed4070 > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 4888ae1 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java > PRE-CREATION > lens-driver-hive/pom.xml 3b8e73a > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 9e3c723 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > 64a6bba > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java > 4f471cb > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 8a5839b > lens-driver-hive/src/test/resources/priority_tests.data 230df95 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java > 38ebc55 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 5233569 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > fef834f > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 67c73b8 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 390071c > > Diff: https://reviews.apache.org/r/32393/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.298s] > [INFO] Lens .............................................. SUCCESS [1.910s] > [INFO] Lens API .......................................... SUCCESS [5.701s] > [INFO] Lens API for server and extensions ................ SUCCESS [7.545s] > [INFO] Lens Cube ......................................... SUCCESS [2:08.787s] > [INFO] Lens DB storage ................................... SUCCESS [9.870s] > [INFO] Lens Query Library ................................ SUCCESS [4.446s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:32.977s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.551s] > [INFO] Lens Server ....................................... SUCCESS [4:21.507s] > [INFO] Lens client ....................................... SUCCESS [19.929s] > [INFO] Lens CLI .......................................... SUCCESS [2:25.156s] > [INFO] Lens Examples ..................................... SUCCESS [0.821s] > [INFO] Lens Distribution ................................. SUCCESS [9.421s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:03.971s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.465s] > [INFO] Lens Regression ................................... SUCCESS [0.475s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:55.919s > [INFO] Finished at: Wed Mar 25 09:06:56 UTC 2015 > [INFO] Final Memory: 98M/1422M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
