----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32614/#review78190 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On March 30, 2015, 10:07 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32614/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 10:07 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-468 > https://issues.apache.org/jira/browse/LENS-468 > > > Repository: lens > > > Description > ------- > > Fixed connection leak by moving connection creation down to prepareInternal > > > Diffs > ----- > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 121b56bf2b513dbaf27562061a404b205c55a74b > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 550a4680d9c2784660dbfe053da2f454f1b9bef7 > > Diff: https://reviews.apache.org/r/32614/diff/ > > > Testing > ------- > > Adding failing test. Waiting for all test results > > > Thanks, > > Jaideep dhok > >
