> On March 30, 2015, 10:35 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java, > > line 120 > > <https://reviews.apache.org/r/32610/diff/1/?file=908991#file908991line120> > > > > We need to read from older properties as well. Or mark this as > > incompatible to reset timeline.present property to override timeline again. > > Rajat Khandelwal wrote: > In that case, this will throw NPE while trying to parse `*.size` property > from table. I think a slight change in design in which you piggyback on > loading timeline from all partitions if loading from properties fails.
I would say that will be too much overhead to pull all partitions. We can check if named strings are present for holes, if not, get the value from direct property. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32610/#review78194 ----------------------------------------------------------- On March 30, 2015, 12:19 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32610/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 12:19 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > handle storing of large collection objects in timeline data structures > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java > b948467e61618695cba5b6fcfdc084d8d26c0c4d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > 79e8a62629b6466f42152678c4267e40f003a5a3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > fb2d0a86d773825cd2a8a635c451e9945b122ce8 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java > d6ee0a17aae8d0952fb685997120dbfc778d2530 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java > 50b75e38f9fcd890e96787399d10434cac6f6045 > > Diff: https://reviews.apache.org/r/32610/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.151s] > [INFO] Lens .............................................. SUCCESS [1.896s] > [INFO] Lens API .......................................... SUCCESS [6.175s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.715s] > [INFO] Lens Cube ......................................... SUCCESS [2:12.362s] > [INFO] Lens DB storage ................................... SUCCESS [10.638s] > [INFO] Lens Query Library ................................ SUCCESS [5.112s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:31.556s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [17.345s] > [INFO] Lens Server ....................................... SUCCESS [6:09.928s] > [INFO] Lens client ....................................... SUCCESS [20.684s] > [INFO] Lens CLI .......................................... SUCCESS [2:34.762s] > [INFO] Lens Examples ..................................... SUCCESS [0.941s] > [INFO] Lens Distribution ................................. SUCCESS [9.567s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:01.797s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.750s] > [INFO] Lens Regression ................................... SUCCESS [0.525s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:55.802s > [INFO] Finished at: Mon Mar 30 11:44:12 UTC 2015 > [INFO] Final Memory: 96M/1058M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
