[ 
https://issues.apache.org/jira/browse/LENS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387994#comment-14387994
 ] 

Hudson commented on LENS-440:
-----------------------------

SUCCESS: Integrated in Lens-Commit #675 (See 
[https://builds.apache.org/job/Lens-Commit/675/])
LENS-440 : Remove rewriter cache and synchronization on rewrite in JDBCDruver 
(amareshwari) (amareshwari: rev 4a5c02a02ae85ecab7d52d9f59c6238923d41593)
* 
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
* lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java


> ColumnarSQLRewriter.rewrite should not be synchronized
> ------------------------------------------------------
>
>                 Key: LENS-440
>                 URL: https://issues.apache.org/jira/browse/LENS-440
>             Project: Apache Lens
>          Issue Type: Improvement
>          Components: driver-jdbc
>    Affects Versions: 2.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Critical
>             Fix For: 2.1
>
>         Attachments: LENS-440.2.patch
>
>
> Right now, ColumnarSQLRewriter.rewrite is synchronized because rewriter is 
> cached in JDBCDriver and it uses all class level variables to keep query 
> rewriting state.
> Having this synchronized will make other queries wait for rewrite. We should 
> have separate rewriter created for each query or move the state out of 
> ColumnarSQLRewriter sothat it need not be synchronized. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to