[
https://issues.apache.org/jira/browse/LENS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaideep Dhok updated LENS-473:
------------------------------
Attachment: lens-473.patch
Attaching patch after last review here, since review board is not behaving well.
Changes
# Get chainName.colname and queried dim attributes for error messages from AST
traversal
# removed method getNonQueryableAttributes
# Added test to validate that dim attrs and chain columns from select clause
don't appear in error message
# Added assert to validate that full chainName.column name comes in error
message instead of chain source column
> Change the queryable field validation logic
> -------------------------------------------
>
> Key: LENS-473
> URL: https://issues.apache.org/jira/browse/LENS-473
> Project: Apache Lens
> Issue Type: Improvement
> Components: cube
> Affects Versions: 2.1
> Reporter: Amareshwari Sriramadasu
> Priority: Critical
> Fix For: 2.1
>
> Attachments: lens-473.patch
>
>
> Right now the field validation logic at
> https://github.com/apache/incubator-lens/blob/master/lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java#L103
> does the following :
> It gets all the dim-attributes queried and measures queried in the user query
> (after expressions are expanded), then it finds if there is single derived
> cube having all the attributes queried and any of measures queried. And makes
> sure all the measures queried are covered by attribute covering derived
> cubes. For chain attributes, it picks source columns of chains as the
> dim-attributes in the above validate.
> Instead it should do the following :
> * Do validation only when query has aggregates
> * Pick dim-attributes (or chain ref columns) only if they are not part of
> aggregate expression.
> * Above mentioned logic of attribute covering and measuring covering logic
> would be the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
