> On April 4, 2015, 7:59 a.m., Himanshu Gahlaut wrote: > > tools/scripts/lens-config.sh, line 79 > > <https://reviews.apache.org/r/32618/diff/1/?file=909158#file909158line79> > > > > It will be easier to understand code, if the piece of code here is only > > concerned about initialization of LENS_SERVER_HEAP and LENS_CLIENT_HEAP and > > does not touches LENS_OPTS. When they are not set the piece of code here > > should initialize them to default values. > > > > DEFAULT_JAVA_HEAP_MAX=-Xmx1024m > > > > if test -z "$LENS_SERVER_HEAP" > > then > > LENS_SERVER_HEAP=DEFAULT_JAVA_HEAP_MAX > > LENS_CLIENT_HEAP=DEFAULT_JAVA_HEAP_MAX > > fi > > > > In this way inclusion of LENS_SERVER_HEAP in LENS_OPTS is separated > > from initializing of LENS_SERVER_HEAP. Separation of concerns. > > > > And I guess LENS_OPTS is already including LENS_SERVER_HEAP later, so > > we don't have to write code for that as well.
Corrected sample code to check for both LENS_SERVER_HEAP and LENS_CLIENT_HEAP separately. if test -z "$LENS_SERVER_HEAP" then LENS_SERVER_HEAP=DEFAULT_JAVA_HEAP_MAX fi if test -z "$LENS_CLIENT_HEAP" then LENS_CLIENT_HEAP=DEFAULT_JAVA_HEAP_MAX fi - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32618/#review78884 ----------------------------------------------------------- On March 30, 2015, 12:12 p.m., Arshad Matin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32618/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 12:12 p.m.) > > > Review request for lens. > > > Bugs: https://issues.apache.org/jira/browse/LENS-428 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/LENS-428 > > > Repository: lens > > > Description > ------- > > LENS-428:LENS_SERVER_HEAP defined in lens-env is not getting honored > > > Diffs > ----- > > tools/scripts/lens-config.sh 0e810cb3a72e6123b20cddbbea24f3bf0375b6c5 > > Diff: https://reviews.apache.org/r/32618/diff/ > > > Testing > ------- > > > Thanks, > > Arshad Matin > >
