> On April 7, 2015, 11:24 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 195 > > <https://reviews.apache.org/r/32610/diff/5/?file=916358#file916358line195> > > > > How does this work if change timeline from endsholes to say ranges? > > > > Can we do such changes right now? If not, we can do a follow up issue.
This can be done in current setup. Set presence property to false for all tables and set one more property indicating which class to use for timeline. That'll load timeline again from all partitions. However, we do need a way for migrating from one timeline to another timeline. This is why Timeline implementations are required to implement Iterable. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32610/#review79123 ----------------------------------------------------------- On April 6, 2015, 6:34 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32610/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 6:34 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > handle storing of large collection objects in timeline data structures > > Addressed all review comments. Again hitting some problem with git. > Equivalent diff at: https://github.com/apache/incubator-lens/pull/7 > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 1835d2f > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 0be8e5f > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartition.java > b948467 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > 79e8a62 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/RangesPartitionTimeline.java > fb2d0a8 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java > d6ee0a1 > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 1094e44 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 6e63483 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestTimePartition.java > 4c98d84 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java > 50b75e3 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > b2ae9b5 > > Diff: https://reviews.apache.org/r/32610/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.282s] > [INFO] Lens .............................................. SUCCESS [1.808s] > [INFO] Lens API .......................................... SUCCESS [5.496s] > [INFO] Lens API for server and extensions ................ SUCCESS [7.267s] > [INFO] Lens Cube ......................................... SUCCESS [2:23.812s] > [INFO] Lens DB storage ................................... SUCCESS [10.480s] > [INFO] Lens Query Library ................................ SUCCESS [4.543s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:32.578s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [18.730s] > [INFO] Lens Server ....................................... SUCCESS [4:32.022s] > [INFO] Lens client ....................................... SUCCESS [20.184s] > [INFO] Lens CLI .......................................... SUCCESS [2:49.930s] > [INFO] Lens Examples ..................................... SUCCESS [0.946s] > [INFO] Lens Distribution ................................. SUCCESS [10.040s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:52.042s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [5.537s] > [INFO] Lens Regression ................................... SUCCESS [0.691s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:39.305s > [INFO] Finished at: Mon Apr 06 09:09:34 UTC 2015 > [INFO] Final Memory: 108M/972M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
