> On April 8, 2015, 11:40 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java, > > line 50 > > <https://reviews.apache.org/r/30251/diff/5/?file=920423#file920423line50> > > > > Again, Don't need the `if` and the local variable > > Raju Bairishetti wrote: > This check is required as we are checking whther the value is >0 or not. > Otherwise we need to add **(mOfDistnctValues.isPresent() && > nummOfDistnctValues.get() > 0)** in assert/checkArgument.
This check is only required as long as we are allowing two ways to create metadata instances: one via `LensClient` and another via `CubeMetastoreClient`. If we have single entry point then such checks can be removed. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30251/#review79306 ----------------------------------------------------------- On April 9, 2015, 6:37 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30251/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 6:37 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-68 > https://issues.apache.org/jira/browse/LENS-68 > > > Repository: lens > > > Description > ------- > > Dim attributes should contain number of possible distinct values it can take. > This can be an approximate number. This would give an idea of how big the > grouping will be when an attribute is chosen for groupby expressions > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 18ee682 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > c4efe52 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java > e23bd8c > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 7e6360e > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 0be8e5f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 859b344 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > baa659c > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 138797e > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 933714c > > Diff: https://reviews.apache.org/r/30251/diff/ > > > Testing > ------- > > Added a checks in the existing unit tests > > > Thanks, > > Raju Bairishetti > >
