----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33162/#review79999 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java <https://reviews.apache.org/r/33162/#comment129748> Can we add getAllFactTablesOfCube also on similar lines? CLI is not required? lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java <https://reviews.apache.org/r/33162/#comment129750> Does it really have to give full XDimensionTable object? Or names suffice? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java <https://reviews.apache.org/r/33162/#comment129749> This should be already happening for getDimensionTable lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java <https://reviews.apache.org/r/33162/#comment129751> StorageTables also get expanded in getDimensionTable. Returning empty would be a problem. - Amareshwari Sriramadasu On April 14, 2015, 7:35 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33162/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 7:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-441 > https://issues.apache.org/jira/browse/LENS-441 > > > Repository: lens > > > Description > ------- > > adding REST method for getting all dimtables of a dimension > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 9de5f79a7b04ab09c753d06a835a94eaea7bbe1a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 0e6d05709dd66165e0eebdeb494096ae85955b68 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 3cf701153d5f30bbd57d7ce3759fe65757fabc80 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 06c352e50eb012177919ac27b6af6eed27a52318 > > Diff: https://reviews.apache.org/r/33162/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
