----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33349/#review80896 -----------------------------------------------------------
Ship it! Looks good. Haven't reviewed the binary files for "copyright" exclusion. Am assuming that is taken care of. - Srikanth Sundarrajan On April 20, 2015, 4:48 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33349/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 4:48 p.m.) > > > Review request for lens and Srikanth Sundarrajan. > > > Bugs: LENS-371 > https://issues.apache.org/jira/browse/LENS-371 > > > Repository: lens > > > Description > ------- > > Changes include : > > - Removes mention of JS files from NOTICE > - Removed pptx files and moved them to svn repo > - Add public domain license in LICENSE file of binary distribution > - Fixed all files containing "Copyright 2007 Apple Inc., all rights > reserved"; Had to regenerate files with keynote. > > > Diffs > ----- > > NOTICE b196dc3 > bin-dist-files/LICENSE f097f81 > bin-dist-files/NOTICE 831ae64 > lens-ml-dist/LICENSE PRE-CREATION > lens-ml-dist/LICENSE.txt 261eeb9 > lens-ml-lib/LICENSE PRE-CREATION > src/site/datalayout.pptx 4ce429a > src/site/diagrams.pptx 3769dec > src/site/resources/images/deployment.png 9e24733 > src/site/resources/images/querystate.png bcadc93 > src/site/resources/images/serverdesign.png bf49b55 > > Diff: https://reviews.apache.org/r/33349/diff/ > > > Testing > ------- > > mvn clean install -DskipTests runs fine. Verified LICENCE and notice files in > binary distribution. > Ran mvn clean package -DskipTests -Papache-release. Verified LICENCE and > NOTICE files in source distribution. > Ran mvn site:run locally and verified the doc is fine. > amareshwari.sr$ git grep "Apple Inc., all rights reserved" . > amareshwari.sr$ > > > Thanks, > > Amareshwari Sriramadasu > >
