> On April 17, 2015, 4:12 a.m., Amareshwari Sriramadasu wrote: > > Is it possible to have testcase for presense key? I think this might break > > more often, if there is no test
for presence key right now we have a failsafe which piggybacks on loading from all partitions in case something goes wrong. We can probably add an error counter if errors are encountered. As far as test cases are concerned, a lot of mocking might need to be done for them. We can park a separate jira for that. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33258/#review80390 ----------------------------------------------------------- On April 16, 2015, 4:21 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33258/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 4:21 p.m.) > > > Review request for lens. > > > Bugs: LENS-512 > https://issues.apache.org/jira/browse/LENS-512 > > > Repository: lens > > > Description > ------- > > blank timeline also has to return all key value pairs > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java > 5867587ddb802973e6f59163f136686718cd0ec9 > > Diff: https://reviews.apache.org/r/33258/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
