+1 for removing --no-prefix. On Wed, May 6, 2015 at 3:05 PM, amareshwarisr . <[email protected]> wrote:
> Hi, > > As documented at > http://lens.incubator.apache.org/developer/contribute.html#Generating_patch > , > we said we will use git diff --no-prefix for generating patch and use git > apply -p0 for applying. Starting this discussion if we want to remove that > going forward. > > There are two reasons why i think we should remove it. > > 1. They are not the default way to generate patch on git. > 2. Review board is not accepting patches generated with --no-prefix to > be uploaded. > > The only reason we had no-prefix was to not include a/ b/ in the paths > sothat it looks clean. > > If people are fine with removing --no-prefix, I can create a follow up jira > for updating contributor doc. > > Thoughts? > > Thanks > Amareshwari >
