----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34043/#review83350 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java <https://reviews.apache.org/r/34043/#comment134327> Can we have corresponding test for this as well? Here, cityStateCapital is chainrefcolumn. All other tests are accessed are accessing chains as chain.column. lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java <https://reviews.apache.org/r/34043/#comment134325> Can we have corresponding test for this as well ? Here, dim2 and countryid are available in any derived cube. This does not look for measures yet. lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java <https://reviews.apache.org/r/34043/#comment134324> Can we have corresponding test for this also? Here, newmeasure does not belong to any derived cube, thus it is not queryable. - Amareshwari Sriramadasu On May 11, 2015, 3:08 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34043/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 3:08 p.m.) > > > Review request for lens. > > > Bugs: LENS-508 > https://issues.apache.org/jira/browse/LENS-508 > > > Repository: lens > > > Description > ------- > > LENS-508: Implement error code and response for 'fields cannot be queried > together' error > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 33e68a5a22dcb95f8e904db189d04637dc3453ff > > lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java > 9419c7816ca5f696e30f30482b5528281abf2c92 > lens-cube/src/main/java/org/apache/lens/cube/error/ConflictingFields.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > c635a7e2e5823bd27766e952189c868a68cc1ccf > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > ddabc25f7a4c1d6fdc4c272685690600d651176a > > lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > b1d7a3203ad5e169930a3dddf6a9fdf55d5cc66a > > Diff: https://reviews.apache.org/r/34043/diff/ > > > Testing > ------- > > I got review request number: 34043 :) > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [5.955s] > [INFO] Lens .............................................. SUCCESS [24.690s] > [INFO] Lens API .......................................... SUCCESS [11.703s] > [INFO] Lens API for server and extensions ................ SUCCESS [11.069s] > [INFO] Lens Cube ......................................... SUCCESS [3:32.836s] > [INFO] Lens DB storage ................................... SUCCESS [14.005s] > [INFO] Lens Query Library ................................ SUCCESS [6.612s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:12.112s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [23.415s] > [INFO] Lens Server ....................................... SUCCESS [9:08.938s] > [INFO] Lens client ....................................... SUCCESS [33.874s] > [INFO] Lens CLI .......................................... SUCCESS [4:04.160s] > [INFO] Lens Examples ..................................... SUCCESS [1.549s] > [INFO] Lens Distribution ................................. SUCCESS [26.447s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:43.477s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [7.476s] > [INFO] Lens Regression ................................... SUCCESS [1.167s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:30.284s > [INFO] Finished at: Mon May 11 14:45:29 GMT 2015 > [INFO] Final Memory: 108M/356M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Himanshu Gahlaut > >
