> On May 5, 2015, 6:11 p.m., Amareshwari Sriramadasu wrote: > > Couple of comments : > > > > - Some code might need changes as LENS-486 went in, which changes response > > returned from REST api > > - I see there is lots of code which is very similar to the code in > > lens-client. I'm not saying lens-regression should use lens-client. But. is > > it an option to consider lens-client instead of many helper methods added? > > If it is not immediately possible, we take it up later.
1. Will make the changes wrt the new changes went in 2. Went through lens-client API and it doesnt have API for all the REST call. As of now, its better to have a seperate helper method, later we can take a call. - Arshad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33842/#review82542 ----------------------------------------------------------- On May 5, 2015, 9:30 a.m., Arshad Matin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33842/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 9:30 a.m.) > > > Review request for lens. > > > Bugs: LENS-242 > https://issues.apache.org/jira/browse/LENS-242 > > > Repository: lens > > > Description > ------- > > LENS-242:Add Helper class for lens-regression > > > Diffs > ----- > > lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/type/APIResult.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java > PRE-CREATION > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 6bd73148738fc96e19f52137707b5aac8597448b > > lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java > 7f462a996a0902989086e505f6145ac7798013fb > pom.xml a0744e4da177947680a6fbc81bbab6456224b602 > > Diff: https://reviews.apache.org/r/33842/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 > s] > [INFO] Lens ............................................... SUCCESS [ 23.994 > s] > [INFO] Lens API ........................................... SUCCESS [ 29.422 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 > s] > [INFO] Lens DB storage .................................... SUCCESS [ 19.038 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 26.845 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 > s] > [INFO] Lens Server ........................................ SUCCESS [02:43 > min] > [INFO] Lens client ........................................ SUCCESS [ 45.831 > s] > [INFO] Lens CLI ........................................... SUCCESS [01:12 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 24.281 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 59.876 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:28 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 > s] > [INFO] Lens Regression .................................... SUCCESS [ 39.851 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:10 min > [INFO] Finished at: 2015-05-05T14:50:23+05:30 > [INFO] Final Memory: 94M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Arshad Matin > >
