> On May 12, 2015, 5:06 a.m., Amareshwari Sriramadasu wrote: > > Please test the document by running mvn site:run and checkinf > > http://localhost:8080 - as documented here - > > http://lens.incubator.apache.org/developer/contribute.html#How_to_update_documentation > > > > Yash, > > Few suggestions for the review request : > > > > - Can you link bugs field when you raise a review request? That will allow > > to click on the link and look at the bug if more details need to be looked > > up. > > - We are following uploading the patch to jira ofter final "ship it!", to > > avoid unnecessary uploads to jira and review request. > > - Also, close the review request as submitted once the patch is committed > > sothat it does not sit in to be reviewed queue.
Points noted. Thanks for the suggestions. I have made few changes in the styling. Will update the patch for a quick re-review. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34041/#review83352 ----------------------------------------------------------- On May 11, 2015, 2:41 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34041/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 2:41 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Remove no-prefix and -p0 from contribute doc > > > Diffs > ----- > > src/site/apt/developer/contribute.apt 821ddab > > Diff: https://reviews.apache.org/r/34041/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
