> On May 13, 2015, 4:47 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, > > line 95 > > <https://reviews.apache.org/r/34105/diff/1/?file=956607#file956607line95> > > > > Also, add jar can take hdfs paths as well - with full uri. We should > > use something like hadoop filesystem api to get all paths matching regex. > > Yash Sharma wrote: > While we can support jars from hdfs but should we ? why would anyone put > jars on hdfs (small file and un-necesarily replicated) ? > > Yash Sharma wrote: > Implemented.
Sorry for late reply. We would support jars/files to be added through an URI. URI can be pointing to hdfs://host:port/path or file:///path or s3:/// or whatever - needs to queryable (we can use hadoop filesystem api) for looking at paths in any of the uri passed. Having support for distributed file system makes process to access it the files even if they are not running on same machines - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34105/#review83561 ----------------------------------------------------------- On May 15, 2015, 6:18 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34105/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 6:18 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Initial patch for - add jar should be able to take regex path and should be > able to add multiple jars. > > Jira: https://issues.apache.org/jira/browse/LENS-513 > > > Diffs > ----- > > lens-cli/pom.xml 7b98523 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 3238edb > lens-server/pom.xml bb12e00 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 5ffc086 > > Diff: https://reviews.apache.org/r/34105/diff/ > > > Testing > ------- > > Yes. > > Testcases: > New testcase: TestLensConnectionCliCommands#testJarCommandsWithRegex > Old testcase modified: TestLensConnectionCliCommands#testJarCommands > > Test on CLI: > > 1. -ve test scenario: > lens-shell>add jar /home/yash/Desktop/rt.jarr > No Jars found in the specified path. > lens-shell>add jar /home/yash/Desktop/*.jarr > No Jars found in the specified path. > > 2. +ve test scenario: > lens-shell>add jar /home/yash/Desktop/*.jar > Add resource succeeded[/home/yash/Desktop/mahout-core-0.9.jar > /home/yash/Desktop/rt.jar ] > > lens-shell>list resources > type=jar path=/home/yash/Desktop/mahout-core-0.9.jar > type=jar path=/home/yash/Desktop/rt.jar > > > Complete build with testcases: > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.822 > s] > [INFO] Lens ............................................... SUCCESS [ 3.751 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.844 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 23.579 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:06 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 22.211 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 19.126 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:48 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.738 > s] > [INFO] Lens Server ........................................ SUCCESS [06:03 > min] > [INFO] Lens client ........................................ SUCCESS [ 41.219 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:09 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 11.513 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 9.081 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:19 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.787 > s] > [INFO] Lens Regression .................................... SUCCESS [ 8.067 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:46 min > [INFO] Finished at: 2015-05-12T19:44:01+05:30 > [INFO] Final Memory: 120M/389M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
