----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34406/#review84482 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java <https://reviews.apache.org/r/34406/#comment135791> Can we make log starting with " Not considering" as it is for other pruning logs? It will make debugging easier when we are looking why some facts are skipped. lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java <https://reviews.apache.org/r/34406/#comment135790> Can we add one fact wit absolute start and end times as well and add test? - Amareshwari Sriramadasu On May 20, 2015, 8:23 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34406/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 8:23 a.m.) > > > Review request for lens. > > > Bugs: LENS-566 > https://issues.apache.org/jira/browse/LENS-566 > > > Repository: lens > > > Description > ------- > > posting early for early comments. remaining: test cases. existing pass > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd > 06f85ee85e6c952367de1937f298ce79554994b0 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 9daccecba212b1d1bb21b749378ea399f8d2b869 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 1fe55d93a3db93c70dc74b70c2ca589c8a2f0753 > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > a25fae641c6486b68d244ff233d0b6a827e41f9c > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 84e5341ad2883b851989129513ec1ee120b91f41 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > a1fea16b7c679abd09de39241cb29b13279c52e0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 6b6a09b0e3628b829417e00c1ca87d371c01693d > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 38b6429841664fed5fc3032d3cbc92f223ec766a > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > b11de10faabf5b0aa2cbcf5cff84120f97a01d96 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > 78578683268a151dfe6a9f217612f36ccf7aed89 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 3e3534c1f5e9b7fa8697a12cbd7f14379ef6ab51 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 5d0e15b303683fa95715c429ac945425c0f918e4 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java > c9c9cc68f8049ce9e9696345e1f3967d8756c964 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > e5e7c56661b6cebd046aacc6c981a246417dfb27 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 5737057f954c07135ddffeefa88f43d41cee35f1 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 4f61671c28e6b10d2256e0f7d55c6f4d12c75fa3 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34406/diff/ > > > Testing > ------- > > added new test class, all passing > > > Thanks, > > Rajat Khandelwal > >
