> On June 1, 2015, 6:18 a.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, > > line 274 > > <https://reviews.apache.org/r/34797/diff/1/?file=974118#file974118line274> > > > > Please have a look at > > http://docs.spring.io/spring-shell/docs/current/api/org/springframework/shell/core/annotation/CliOption.html > > and decide what should be appropriate values for `specifiedDefaultValue` > > and `unspecifiedDefaultValue`
I think having specifiedDefaultValue as false is non-intutive. I'll set both unspecifiedDefaultValue and specifiedDefaultValue as true. - Pranav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34797/#review85940 ----------------------------------------------------------- On June 1, 2015, 9:15 a.m., Pranav Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34797/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 9:15 a.m.) > > > Review request for lens. > > > Bugs: LENS-590 > https://issues.apache.org/jira/browse/LENS-590 > > > Repository: lens > > > Description > ------- > > lens-590 > > > per review comments from rajat: added cli.apt and adjusted cli params for > query results commands > > > improved help message for query results CLI option > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 32a89ac98230d642738e1954b965c692c7235507 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > cd8bf166e11786ae8ec26df8d03dd381ef62d787 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java > 4472a80b9e8b8b7243ec6d15a854867bb24dcce1 > src/site/apt/user/cli.apt 2016bfddf38751fd98bedb8163d61c6af5b99be3 > > Diff: https://reviews.apache.org/r/34797/diff/ > > > Testing > ------- > > tests have come out clean > > > Thanks, > > Pranav Agarwal > >
